Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a handful of clippy warnings #2539

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Fixes a handful of clippy warnings #2539

merged 3 commits into from
Aug 25, 2023

Conversation

collinc97
Copy link
Collaborator

No description provided.

@collinc97 collinc97 requested a review from d0cd August 18, 2023 23:49
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #2539 (16473f2) into testnet3 (a255113) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           testnet3    #2539      +/-   ##
============================================
- Coverage     79.03%   79.01%   -0.02%     
============================================
  Files           159      159              
  Lines          5309     5309              
  Branches       5309     5309              
============================================
- Hits           4196     4195       -1     
- Misses         1113     1114       +1     
Files Changed Coverage Δ
...ompiler/passes/src/flattening/flatten_statement.rs 62.96% <21.42%> (ø)
compiler/ast/src/functions/mod.rs 100.00% <100.00%> (ø)
...er/passes/src/code_generation/visit_expressions.rs 77.92% <100.00%> (ø)
...mpiler/passes/src/flattening/flatten_expression.rs 81.64% <100.00%> (+0.11%) ⬆️
.../passes/src/function_inlining/inline_expression.rs 94.73% <100.00%> (ø)
...r/passes/src/function_inlining/inline_statement.rs 63.15% <100.00%> (ø)
.../src/static_single_assignment/rename_expression.rs 94.49% <100.00%> (ø)
...iler/passes/src/type_checking/check_expressions.rs 82.35% <100.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit de2b2a2 into testnet3 Aug 25, 2023
7 of 8 checks passed
@d0cd d0cd deleted the fix/noop-method-calls branch August 25, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants