-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dependencies. #28382
Clean up dependencies. #28382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you forsee any issues with maintainability by moving all of these workspace dependencies? Curious, does it reduce build time?
I doubt it reduces build times generally. Maybe in some weird cases where some crates were getting redundantly built multiple times? Not sure. IMO the main advantage is just keeping the versions and feature flags in one place. We bump the version of Leo or a dependency, we don't have to search across a ton of different Cargo.toml files to make changes. |
d571cec
to
c03ba8b
Compare
|
||
[dependencies.indexmap] | ||
version = "1.9" | ||
features = [ "serde-1" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the workspace dependency for indexmap need the serde-1
feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding from reading indexmap docs is that serde-1
is sort of deprecated now, and instead we're supposed to use serde
.
These release notes mention serde-1
being removed (although for a later version than we're using)
https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's upgrade to 2.0.0
and use serde
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched the remove
calls to remove_shift
, as discussed, although that does potentially change behavior.
c7319af
to
f935e01
Compare
Remove unused deps. Use workspace deps where appropriate.
f935e01
to
01225f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remove unused deps. Use workspace deps where appropriate.