Improve handling of guards while flattening. #28392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple things to note: This doesn't currently use the cached conditional idea for guarding against early returns for asserts... so in principle a lot of unnecessary code could be generated if there are multiple asserts following a bunch of early returns. Also, the ntzseals.leo test now passes because it doesn't generate too much code. |
mikebenfield
force-pushed
the
ifelse
branch
3 times, most recently
from
e52ea05
to
9b7aab2
Compare
d0cd
requested changes
Oct 15, 2024
d0cd
reviewed
Oct 17, 2024
d0cd
requested changes
Oct 17, 2024
Specifically three changes are made:
1. Cache Anded together chains of conditionals for early returns.
This prevents quadratic code being generated in the face of a chain
of ifs like
```
if a { return 0u32; } else if b { return 1u32 } else if ...
```
2. Take into account early returns for asserts, and cache the
when reconstructing the assert, as with caching them for early returns.
Fixes #28386, #28387
|
Alright; I've made a few changes and I think I've addressed everything including the SSA issue. Note that I rebased and changed the commit message a bit too. |
d0cd
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically two changes are made:
Fixes #28386, #28387