Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature - Add GitHub Action to add contributors to README" #4679

Merged
1 commit merged into from
Nov 8, 2023

Conversation

christianwwwwwwww
Copy link
Contributor

Reverts #3824

@christianwwwwwwww christianwwwwwwww requested a review from a user November 8, 2023 19:17
@ghost
Copy link

ghost commented Nov 8, 2023

Reverting during stress testing period. Will revisit and address all bugs as soon as stress testing is completed. In the meantime, contributor additions will balloon, we will address these later.

@ghost ghost merged commit be75b14 into testnet3 Nov 8, 2023
14 checks passed
@ghost ghost deleted the revert-3824-readme-github-action branch November 8, 2023 19:27
@MarkStepa
Copy link

MarkStepa commented Nov 21, 2023

@christianwwwwwwww
@aharshbe

there is little missing in title check:

https://github.com/christianwwwwwwww/leo/blob/472ddbd86c013b39172bd0064a8e74f37626bd72/.github/scripts/add_contributor.js#L14C8-L14C8
i suggest something like this:

if (!issueTitle.startsWith("Add ") || !issueTitle.includes("Badge") || !issueTitle.endsWith(" to contributors")) {

cos temple right now look like this:
https://github.com/AleoHQ/leo/blob/57c8c722aa618bbef37349a7050a4f4697d32217/.github/ISSUE_TEMPLATE/4_badge.md?plain=1#L4

[Badge - YOUR_GH_USERNAME]

image

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants