Add CI for Docker images #2974
Merged
Add CI for Docker images #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timschumi
force-pushed
the
docker-ci
branch
from
7f4fa2f
to
8ecdeaf
Compare
|
Depends on #2971, since that unbreaks the docker build in the first place. |
timschumi
force-pushed
the
docker-ci
branch
from
8ecdeaf
to
5094717
Compare
hakusaro
previously approved these changes
Oct 21, 2023
timschumi
dismissed
hakusaro’s stale review
The merge-base changed after approval.
hakusaro
previously approved these changes
Oct 21, 2023
These kept Docker buildx from automatically building for multiple platforms.
timschumi
dismissed
hakusaro’s stale review
The merge-base changed after approval.
|
Bump? :^) |
drunderscore
approved these changes
Dec 27, 2023
|
@hakusaro Any chance that we can get this reapproved and pulled in? |
|
Any update on this ? :) @hakusaro @timschumi ? |
I think I did all that I could do, now it's just waiting on someone to merge it. After all, the PR was already approved once before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't push the image anywhere, it just makes sure that the Docker build works.
Note that this removes the recommendation to use
docker buildeven for native builds, since users would now have to set bothTARGETPLATFORMandBUILDPLATFORMmanually.docker buildxis available since Docker engine 19.03, which has been released in late 2019, so it isn't as bleeding-edge as it once was and more widely available now.