Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy initialize TextLog._logWriter #3023

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Lazy initialize TextLog._logWriter #3023

merged 1 commit into from
Apr 13, 2024

Commits on Feb 18, 2024

  1. Lazy initialize TextLog._logWriter 

    There is an instance of this in SqlLog that's used as a backup, but since the StreamWriter is created in the constructor, the file is created too. This means that you'll get an empty text log created, every time a server starts up, even if you have text logs disabled. This is especially problematic when you have a multi-server setup with file write conflicts.
    @ZakFahey
    ZakFahey committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    a19ac72 View commit details
    Browse the repository at this point in the history