Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /help, /me, and /p commands can't work in non-English languages #3039

Open
wants to merge 7 commits into
base: general-devel
Choose a base branch
from

Conversation

ACaiCat
Copy link

@ACaiCat ACaiCat commented Jul 31, 2024

When TShock runs in a non-English language, vanilla commands prefix will be localized.

eg.(Chinese) /help (English command prefix) => /帮助 (Chinese command prefix)

TShock.OnChat cannot correctly handle vanilla command prefixes

e.g.(Chinese) When a player use /help, TShock will execute /帮助 (causing the command to not be found).
image

Invalid command entered. Type /help for a list of valid commands.

This PR add EnglishLanguage.GetCommandPrefixByName to get English vanilla command prefix.

image

@ACaiCat
Copy link
Author

ACaiCat commented Jul 31, 2024

Solve #2914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant