Skip to content

Commit

Permalink
UOE-9681: fix prebid validation in ow module (#650)
Browse files Browse the repository at this point in the history
  • Loading branch information
@pm-nilesh-chate
pm-nilesh-chate authored Nov 21, 2023
1 parent c6c9682 commit 92b46a6
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 2 deletions.
8 changes: 8 additions & 0 deletions modules/pubmatic/openwrap/beforevalidationhook.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ func (m OpenWrap) handleBeforeValidationHook(
}
}()

// return prebid validation error
if len(payload.BidRequest.Imp) == 0 || (payload.BidRequest.Site == nil && payload.BidRequest.App == nil) {
result.Reject = false
m.metricEngine.RecordBadRequests(rCtx.Endpoint, getPubmaticErrorCode(nbr.InvalidRequestExt))
m.metricEngine.RecordNobidErrPrebidServerRequests(rCtx.PubIDStr, nbr.InvalidRequestExt)
return result, nil
}

//Do not execute the module for requests processed in SSHB(8001)
if rCtx.Sshb == "1" {
result.Reject = false
Expand Down
58 changes: 56 additions & 2 deletions modules/pubmatic/openwrap/beforevalidationhook_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1874,6 +1874,7 @@ func TestOpenWrap_handleBeforeValidationHook(t *testing.T) {
},
},
},
bidrequest: json.RawMessage(`{"id":"123-456-789","imp":[{"id":"123","banner":{"format":[{"w":728,"h":90},{"w":300,"h":250}],"w":700,"h":900},"video":{"mimes":["video/mp4","video/mpeg"],"w":640,"h":480},"tagid":"adunit","bidfloor":4.3,"bidfloorcur":"USD","ext":{"bidder":{"pubmatic":{"keywords":[{"key":"pmzoneid","value":["val1","val2"]}]}},"prebid":{}}}],"site":{"domain":"test.com","page":"www.test.com","publisher":{"id":"5890"}},"device":{"ua":"Mozilla/5.0(X11;Linuxx86_64)AppleWebKit/537.36(KHTML,likeGecko)Chrome/52.0.2743.82Safari/537.36","ip":"123.145.167.10"},"user":{"id":"119208432","buyeruid":"1rwe432","yob":1980,"gender":"F","geo":{"country":"US","region":"CA","metro":"90001","city":"Alamo"}},"wseat":["Wseat_0","Wseat_1"],"bseat":["Bseat_0","Bseat_1"],"cur":["cur_0","cur_1"],"wlang":["Wlang_0","Wlang_1"],"bcat":["bcat_0","bcat_1"],"badv":["badv_0","badv_1"],"bapp":["bapp_0","bapp_1"],"source":{"ext":{"omidpn":"MyIntegrationPartner","omidpv":"7.1"}},"ext":{"prebid":{},"wrapper":{"test":123,"profileid":123,"versionid":1,"wiid":"test_display_wiid"}}}`),
},
want: hookstage.HookResult[hookstage.BeforeValidationRequestPayload]{
Reject: false,
Expand All @@ -1882,8 +1883,9 @@ func TestOpenWrap_handleBeforeValidationHook(t *testing.T) {
{
name: "empty_module_context",
args: args{
ctx: context.Background(),
moduleCtx: hookstage.ModuleInvocationContext{},
ctx: context.Background(),
moduleCtx: hookstage.ModuleInvocationContext{},
bidrequest: json.RawMessage(`{"id":"123-456-789","imp":[{"id":"123","banner":{"format":[{"w":728,"h":90},{"w":300,"h":250}],"w":700,"h":900},"video":{"mimes":["video/mp4","video/mpeg"],"w":640,"h":480},"tagid":"adunit","bidfloor":4.3,"bidfloorcur":"USD","ext":{"bidder":{"pubmatic":{"keywords":[{"key":"pmzoneid","value":["val1","val2"]}]}},"prebid":{}}}],"site":{"domain":"test.com","page":"www.test.com","publisher":{"id":"5890"}},"device":{"ua":"Mozilla/5.0(X11;Linuxx86_64)AppleWebKit/537.36(KHTML,likeGecko)Chrome/52.0.2743.82Safari/537.36","ip":"123.145.167.10"},"user":{"id":"119208432","buyeruid":"1rwe432","yob":1980,"gender":"F","geo":{"country":"US","region":"CA","metro":"90001","city":"Alamo"}},"wseat":["Wseat_0","Wseat_1"],"bseat":["Bseat_0","Bseat_1"],"cur":["cur_0","cur_1"],"wlang":["Wlang_0","Wlang_1"],"bcat":["bcat_0","bcat_1"],"badv":["badv_0","badv_1"],"bapp":["bapp_0","bapp_1"],"source":{"ext":{"omidpn":"MyIntegrationPartner","omidpv":"7.1"}},"ext":{"prebid":{},"wrapper":{"test":123,"profileid":123,"versionid":1,"wiid":"test_display_wiid"}}}`),
},
fields: fields{
cache: mockCache,
Expand All @@ -1904,6 +1906,7 @@ func TestOpenWrap_handleBeforeValidationHook(t *testing.T) {
"test_rctx": "test",
},
},
bidrequest: json.RawMessage(`{"id":"123-456-789","imp":[{"id":"123","banner":{"format":[{"w":728,"h":90},{"w":300,"h":250}],"w":700,"h":900},"video":{"mimes":["video/mp4","video/mpeg"],"w":640,"h":480},"tagid":"adunit","bidfloor":4.3,"bidfloorcur":"USD","ext":{"bidder":{"pubmatic":{"keywords":[{"key":"pmzoneid","value":["val1","val2"]}]}},"prebid":{}}}],"site":{"domain":"test.com","page":"www.test.com","publisher":{"id":"5890"}},"device":{"ua":"Mozilla/5.0(X11;Linuxx86_64)AppleWebKit/537.36(KHTML,likeGecko)Chrome/52.0.2743.82Safari/537.36","ip":"123.145.167.10"},"user":{"id":"119208432","buyeruid":"1rwe432","yob":1980,"gender":"F","geo":{"country":"US","region":"CA","metro":"90001","city":"Alamo"}},"wseat":["Wseat_0","Wseat_1"],"bseat":["Bseat_0","Bseat_1"],"cur":["cur_0","cur_1"],"wlang":["Wlang_0","Wlang_1"],"bcat":["bcat_0","bcat_1"],"badv":["badv_0","badv_1"],"bapp":["bapp_0","bapp_1"],"source":{"ext":{"omidpn":"MyIntegrationPartner","omidpv":"7.1"}},"ext":{"prebid":{},"wrapper":{"test":123,"profileid":123,"versionid":1,"wiid":"test_display_wiid"}}}`),
},
fields: fields{
cache: mockCache,
Expand All @@ -1926,6 +1929,7 @@ func TestOpenWrap_handleBeforeValidationHook(t *testing.T) {
},
},
},
bidrequest: json.RawMessage(`{"id":"123-456-789","imp":[{"id":"123","banner":{"format":[{"w":728,"h":90},{"w":300,"h":250}],"w":700,"h":900},"video":{"mimes":["video/mp4","video/mpeg"],"w":640,"h":480},"tagid":"adunit","bidfloor":4.3,"bidfloorcur":"USD","ext":{"bidder":{"pubmatic":{"keywords":[{"key":"pmzoneid","value":["val1","val2"]}]}},"prebid":{}}}],"site":{"domain":"test.com","page":"www.test.com","publisher":{"id":"5890"}},"device":{"ua":"Mozilla/5.0(X11;Linuxx86_64)AppleWebKit/537.36(KHTML,likeGecko)Chrome/52.0.2743.82Safari/537.36","ip":"123.145.167.10"},"user":{"id":"119208432","buyeruid":"1rwe432","yob":1980,"gender":"F","geo":{"country":"US","region":"CA","metro":"90001","city":"Alamo"}},"wseat":["Wseat_0","Wseat_1"],"bseat":["Bseat_0","Bseat_1"],"cur":["cur_0","cur_1"],"wlang":["Wlang_0","Wlang_1"],"bcat":["bcat_0","bcat_1"],"badv":["badv_0","badv_1"],"bapp":["bapp_0","bapp_1"],"source":{"ext":{"omidpn":"MyIntegrationPartner","omidpv":"7.1"}},"ext":{"prebid":{},"wrapper":{"test":123,"profileid":123,"versionid":1,"wiid":"test_display_wiid"}}}`),
},
want: hookstage.HookResult[hookstage.BeforeValidationRequestPayload]{
Reject: false,
Expand Down Expand Up @@ -2531,6 +2535,56 @@ func TestOpenWrap_handleBeforeValidationHook(t *testing.T) {
wantErr: false,
isRequestNotRejected: true,
},
{
name: "prebid-validation-errors-imp-missing",
args: args{
ctx: context.Background(),
moduleCtx: hookstage.ModuleInvocationContext{
ModuleContext: hookstage.ModuleContext{
"rctx": models.RequestCtx{
PubIDStr: "1234",
Endpoint: models.EndpointV25,
},
},
},
bidrequest: json.RawMessage(`{}`),
},
fields: fields{
cache: mockCache,
metricEngine: mockEngine,
},
setup: func() {
mockEngine.EXPECT().RecordBadRequests(models.EndpointV25, 18)
mockEngine.EXPECT().RecordNobidErrPrebidServerRequests("1234", 604)
},
want: hookstage.HookResult[hookstage.BeforeValidationRequestPayload]{},
wantErr: false,
},
{
name: "prebid-validation-errors-site-and-app-missing",
args: args{
ctx: context.Background(),
moduleCtx: hookstage.ModuleInvocationContext{
ModuleContext: hookstage.ModuleContext{
"rctx": models.RequestCtx{
PubIDStr: "1234",
Endpoint: models.EndpointV25,
},
},
},
bidrequest: json.RawMessage(`{"id":"123-456-789","imp":[{"id":"123","banner":{"format":[{"w":728,"h":90},{"w":300,"h":250}],"w":700,"h":900},"video":{"mimes":["video/mp4","video/mpeg"],"w":640,"h":480},"tagid":"adunit","bidfloor":4.3,"bidfloorcur":"USD","ext":{"bidder":{"pubmatic":{"keywords":[{"key":"pmzoneid","value":["val1","val2"]}]}},"prebid":{}}}],"device":{"ua":"Mozilla/5.0(X11;Linuxx86_64)AppleWebKit/537.36(KHTML,likeGecko)Chrome/52.0.2743.82Safari/537.36","ip":"123.145.167.10"},"user":{"id":"119208432","buyeruid":"1rwe432","yob":1980,"gender":"F","geo":{"country":"US","region":"CA","metro":"90001","city":"Alamo"}},"wseat":["Wseat_0","Wseat_1"],"bseat":["Bseat_0","Bseat_1"],"cur":["cur_0","cur_1"],"wlang":["Wlang_0","Wlang_1"],"bcat":["bcat_0","bcat_1"],"badv":["badv_0","badv_1"],"bapp":["bapp_0","bapp_1"],"source":{"ext":{"omidpn":"MyIntegrationPartner","omidpv":"7.1"}},"ext":{"prebid":{},"wrapper":{"test":123,"profileid":123,"versionid":1,"wiid":"test_display_wiid"}}}`),
},
fields: fields{
cache: mockCache,
metricEngine: mockEngine,
},
setup: func() {
mockEngine.EXPECT().RecordBadRequests(models.EndpointV25, 18)
mockEngine.EXPECT().RecordNobidErrPrebidServerRequests("1234", 604)
},
want: hookstage.HookResult[hookstage.BeforeValidationRequestPayload]{},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down

0 comments on commit 92b46a6

Please sign in to comment.