Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-1390,UOE-9175: add missing fields in owlogger & tracker so that OW module can run independently #626

Merged
merged 97 commits into from
Nov 20, 2023
Merged

OTT-1390,UOE-9175: add missing fields in owlogger & tracker so that OW module can run independently #626

merged 97 commits into from
Nov 20, 2023

Conversation

pm-nilesh-chate
Copy link
Collaborator

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

pm-saurabh-narkhede and others added 30 commits August 24, 2023 09:54
@pm-saurabh-narkhede
UOE-9175: Migrate Tracker from HB to pubmatic module
30455c0
@ashishshinde-pubm
adding UTS
202d27f
@ashishshinde-pubm
fix errors
82dc9c9
@ashishshinde-pubm
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
d210fcb 
…UOE-9175-ci-owlogger
@ashishshinde-pubm
Fix errors
219ad28
@ashishshinde-pubm
fix observations
98460aa
@ashishshinde-pubm
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
c4801b5 
…UOE-9175-ci-owlogger
@ashishshinde-pubm
adding few changes
ab495f4
@pm-saurabh-narkhede
UOE-9175: Migrate Tracker from HB to pubmatic module
7bcbc62
@pm-saurabh-narkhede
add test
253db10
@pm-saurabh-narkhede
changes for tracker
3183d87
@pm-saurabh-narkhede
currency conversion
d4d0d3a
@pm-aadit-patil @ashishshinde-pubm
UOE-9222:Set 0x0 default size inside logger for kgpv in case of video…
7ad1fb6 
… bids
@pm-saurabh-narkhede
currencyConversion in deps
4cdd580
@ashishshinde-pubm
make nbr pointer
6ef9ae7
@pm-saurabh-narkhede
unmarshall responseExt
fa96324
@ashishshinde-pubm
UOE-9175: add unit test cases
b5bb4b8
@ashishshinde-pubm
Merge branch 'UOE-9175-ci' of github.com:PubMatic-OpenWrap/prebid-ser…
cd4889f 
…ver into UOE-9175-ci-owlogger
@ashishshinde-pubm
Fix errors
15de2f9
@ashishshinde-pubm
adding more test cases
8320d0d
@ashishshinde-pubm
Add TestNonBRCodesInHandleAuctionResponseHook UTs
6f178dd
@ashishshinde-pubm
Refactor GetAdFormat
e975bd9
@ashishshinde-pubm
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
8aa4341 
…UOE-9175-ci-owlogger
@ashishshinde-pubm
Correct version id in logger
4bf0211
@ashishshinde-pubm
logger: fetch bidExt by unmarshaling bid.Ext
4007559
@pm-saurabh-narkhede
add test cases
2af29f1
@ashishshinde-pubm
Request.Tmax will have highest priority
9ac5af7
@pm-nikhil-vaidya
OTT-1402 :: Make BidId unique for auction in auctionresponsehook
d15b8f1
@pm-nikhil-vaidya
OTT-1402 :: Added test cases for corner case
7a0f972
@pm-nikhil-vaidya
OTT-1402 :: code review comments addressed
d63ff56
pm-nilesh-chate
pm-nilesh-chate commented Nov 8, 2023
View reviewed changes
Copy link
Collaborator Author

@pm-nilesh-chate pm-nilesh-chate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment. Still reviewing UTs

exchange/exchange_test.go Show resolved Hide resolved
analytics/pubmatic/logger.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/auctionresponsehook.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/beforevalidationhook.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/matchedimpression.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/util.go Outdated Show resolved Hide resolved
@pm-nilesh-chate
Copy link
Collaborator Author

TODO:

  1. MatchedImpression
  2. Review KGPV, etc code
  3. Review UT
  4. Prometheus key prefix (separate registry for SSHB and OW module)

@ashishshinde-pubm
Merge branch 'UOE-logger-tracker-test' of github.com:PubMatic-OpenWra…
02a0255 
…p/prebid-server into UOE-logger-tracker-test
@ashishshinde-pubm ashishshinde-pubm marked this pull request as ready for review November 8, 2023 09:13
@pm-saurabh-narkhede pm-saurabh-narkhede changed the title OTT-1390: add missing fields in owlogger & tracker so that OW module can run independently OTT-1390,UOE-9175: add missing fields in owlogger & tracker so that OW module can run independently Nov 8, 2023
ashishshinde-pubm and others added 2 commits November 20, 2023 11:19
@ashishshinde-pubm
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
df769c6 
…UOE-logger-tracker-test
@pm-nilesh-chate
Revert "UOE-9681: mapping not uploaded nbr (#643)"
d0f58a4 
* UOE-9681: fix eg, en multicurrency case (#644)

* Revert "UOE-9681: mapping not uploaded nbr (#643)"

This reverts commit 7cffa2e.

* revert unwanted file

* remove OriginalBidCPMUSD from valid bids

* fix eg logger check

* drop nonmapped nonpubmatic bidder

* Revert "UOE-9681: mapping not uploaded nbr (#643)" (#645)

This reverts commit 7cffa2e.
@ashishshinde-pubm ashishshinde-pubm self-requested a review November 20, 2023 08:01
ashishshinde-pubm
ashishshinde-pubm approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@ashishshinde-pubm ashishshinde-pubm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran the automation, did not observe any logger related failures

@ashishshinde-pubm ashishshinde-pubm merged commit f275b8f into ci Nov 20, 2023
1 check passed
@ashishshinde-pubm ashishshinde-pubm deleted the UOE-logger-tracker-test branch June 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvinashKapre AvinashKapre AvinashKapre left review comments

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone left review comments

@ashishshinde-pubm ashishshinde-pubm ashishshinde-pubm approved these changes

@pm-saurabh-narkhede pm-saurabh-narkhede pm-saurabh-narkhede approved these changes

@pm-nikhil-vaidya pm-nikhil-vaidya pm-nikhil-vaidya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pm-nilesh-chate @Pubmatic-Dhruv-Sonone @pm-nikhil-vaidya @pm-saurabh-narkhede @ashishshinde-pubm @AvinashKapre @pm-aadit-patil