Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-UOE-10137 : Fetch platform details from wrapper_profile table and move to profile level #727

Merged
merged 9 commits into from
Apr 8, 2024
Merged

PB-UOE-10137 : Fetch platform details from wrapper_profile table and move to profile level #727

merged 9 commits into from
Apr 8, 2024

Conversation

pm-priyanka-bagade
Copy link
Collaborator

No description provided.

pm-nilesh-chate
pm-nilesh-chate reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@pm-nilesh-chate pm-nilesh-chate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor nitpicks

modules/pubmatic/openwrap/database/mysql/partner_config.go Show resolved Hide resolved
modules/pubmatic/openwrap/database/mysql/partner_config.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/database/mysql/partner_config_test.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/database/mysql/partner_config_test.go Outdated Show resolved Hide resolved
modules/pubmatic/openwrap/database/mysql/partner_config_test.go Outdated Show resolved Hide resolved
@pm-priyanka-bagade pm-priyanka-bagade changed the title As a developer I should be able to identify the platform type UOE-10137 : Fetch platform details from wrapper_profile table Mar 11, 2024
AvinashKapre
AvinashKapre reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@AvinashKapre AvinashKapre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the queries in app-resource.yaml HB file and inform the updation.

@pm-priyanka-bagade pm-priyanka-bagade marked this pull request as ready for review March 13, 2024 10:32
@pm-priyanka-bagade pm-priyanka-bagade changed the title UOE-10137 : Fetch platform details from wrapper_profile table UOE-10137 : Fetch platform details from wrapper_profile table and move to profile level Apr 8, 2024
@pm-priyanka-bagade pm-priyanka-bagade changed the title UOE-10137 : Fetch platform details from wrapper_profile table and move to profile level PB-UOE-10137 : Fetch platform details from wrapper_profile table and move to profile level Apr 8, 2024
@pm-priyanka-bagade pm-priyanka-bagade changed the base branch from ci_backup_20240402 to ci April 8, 2024 08:50
@pm-nilesh-chate pm-nilesh-chate merged commit c0423b8 into ci Apr 8, 2024
@pm-nilesh-chate pm-nilesh-chate deleted the PB-UOE-10137 branch April 8, 2024 10:06
pm-priyanka-bagade added a commit that referenced this pull request Apr 11, 2024
@pm-priyanka-bagade
Revert "UOE-10137: Fetch platform type from wrapper profile table (#727…
1beada9 
…)"

This reverts commit c0423b8.
pm-priyanka-bagade added a commit that referenced this pull request Apr 11, 2024
@pm-priyanka-bagade
Revert "UOE-10137: Fetch platform type from wrapper profile table (#727…
767d0cb 
…)" (#749)

* Revert "UOE-10137: fix UT related to (#746) (#747)"

This reverts commit 0988a94.

* Revert "UOE-10137: Fetch platform type from wrapper profile table (#727)"

This reverts commit c0423b8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone left review comments

@AvinashKapre AvinashKapre AvinashKapre approved these changes

@pm-nilesh-chate pm-nilesh-chate pm-nilesh-chate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pm-priyanka-bagade @Pubmatic-Dhruv-Sonone @pm-nilesh-chate @AvinashKapre