Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTT-1687: add support for owortb_testbidder (oRTB integration) #735

Merged
merged 13 commits into from
May 21, 2024
Merged

OTT-1687: add support for owortb_testbidder (oRTB integration) #735

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3ff6d2f
OTT-1687:ortbbidder support
ashishshinde-pubm Mar 22, 2024
6173014
OTT-1687: fix race-integration test case
ashishshinde-pubm Mar 22, 2024
9bab81f
address review comments
ashishshinde-pubm Mar 25, 2024
1c28d86
fix semgrep rules
ashishshinde-pubm Mar 25, 2024
e08c86f
OTT-1687: address review comments
ashishshinde-pubm Mar 28, 2024
3582ee7
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
ashishshinde-pubm Mar 28, 2024
0671490
code refactoring
ashishshinde-pubm Mar 29, 2024
98bb061
code refactoring
ashishshinde-pubm Mar 29, 2024
149da61
OTT-1687: address review comments
ashishshinde-pubm Apr 1, 2024
b7b66a0
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
ashishshinde-pubm May 17, 2024
73f585e
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
ashishshinde-pubm May 20, 2024
4d63332
OTT-1734: map bidder-params in bidRequest body (#786)
ashishshinde-pubm May 20, 2024
209edef
update yaml
ashishshinde-pubm May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions adapters/adapterstest/test_json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ func getTestExtraRequestInfo(t *testing.T, filename string, spec *testSpec, isAm
} else if isVideoTest {
reqInfo.PbsEntryPoint = "video"
}
reqInfo = updateRequestInfoForOW(reqInfo, filename) // OW specific : required for oRTB bidder

return &reqInfo
}
Expand Down
20 changes: 20 additions & 0 deletions adapters/adapterstest/test_json_ow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package adapterstest

import (
"strings"

"github.com/prebid/prebid-server/adapters"
"github.com/prebid/prebid-server/openrtb_ext"
)

// updateRequestInfoForOW updates the reqInfo as per OW requirement
func updateRequestInfoForOW(reqInfo adapters.ExtraRequestInfo, fileName string) adapters.ExtraRequestInfo {
// for oRTB bidders (having prefix as 'ortb_', set the bidderName from file)
if strings.HasPrefix(fileName, "ortb_") {
files := strings.Split(fileName, "/")
if len(files) > 0 {
reqInfo.BidderCoreName = openrtb_ext.BidderName(files[0])
}
}
return reqInfo
}
2 changes: 2 additions & 0 deletions adapters/bidder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ type ExtraRequestInfo struct {
PbsEntryPoint metrics.RequestType
GlobalPrivacyControlHeader string
CurrencyConversions currency.Conversions

BidderCoreName openrtb_ext.BidderName // OW specific: required for oRTB bidder
}

func NewExtraRequestInfo(c currency.Conversions) ExtraRequestInfo {
Expand Down
139 changes: 139 additions & 0 deletions adapters/ortbbidder/ortb_test_multi_requestmode/exemplary/multi_imps_video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
{
"mockBidRequest": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id-1",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_1",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_1": "value_1"
}
}
}
}
},
{
"id": "test-imp-id-2",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_2",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_2": "value_2"
}
}
}
}
}
]
},
"httpCalls": [
{
"expectedRequest": {
"uri": "http://test_bidder.com",
"body": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id-1",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_1",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_1": "value_1"
}
}
}
}
},
{
"id": "test-imp-id-2",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_2",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_2": "value_2"
}
}
}
}
}
]
}
},
"mockResponse": {
"status": 200,
"body": {
"id": "test-request-id",
"seatbid": [
{
"seat": "magnite",
"bid": [{
"id": "bid-1",
"impid": "test-imp-id-1",
"price": 0.500000,
"adm": "some-test-ad",
"crid": "crid_10",
"mtype": 2
},{
"id": "bid-2",
"impid": "test-imp-id-2",
"price": 10,
"adm": "some-test-ad-2",
"crid": "crid_10",
"mtype": 2
}]
}
],
"cur": "USD"
}
}
}
],

"expectedBidResponses": [
{
"bids": [
{
"bid": {
"id": "bid-1",
"impid": "test-imp-id-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"mtype":2
},
"type": "video"
},
{
"bid": {
"id": "bid-2",
"impid": "test-imp-id-2",
"price": 10,
"adm": "some-test-ad-2",
"crid": "crid_10",
"mtype":2
},
"type": "video"
}
]
}
]
}
166 changes: 166 additions & 0 deletions adapters/ortbbidder/ortb_test_single_requestmode/exemplary/multi_imps_video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
{
"mockBidRequest": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id-1",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_1",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_1": "value_1"
}
}
}
}
},
{
"id": "test-imp-id-2",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_2",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_2": "value_2"
}
}
}
}
}
]
},
"httpCalls": [
{
"expectedRequest": {
"uri": "http://test_bidder.com",
"body": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id-1",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_1",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_1": "value_1"
}
}
}
}
}
]
}
},
"mockResponse": {
"status": 200,
"body": {
"id": "test-request-id",
"seatbid": [
{
"seat": "magnite",
"bid": [{
"id": "bid-1",
"impid": "test-imp-id-1",
"price": 0.500000,
"adm": "some-test-ad",
"crid": "crid_10",
"mtype": 2
}]
}
],
"cur": "USD"
}
}
},
{
"expectedRequest": {
"uri": "http://test_bidder.com",
"body": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id-2",
"video": {
"mimes": ["video/mp4"]
},
"tagid": "tagid_2",
"ext": {
"prebid": {
"bidder": {
"magnite": {
"bidder_param_2": "value_2"
}
}
}
}
}
]
}
},
"mockResponse": {
"status": 200,
"body": {
"id": "test-request-id",
"seatbid": [
{
"seat": "magnite",
"bid": [{
"id": "bid-2",
"impid": "test-imp-id-2",
"price": 10,
"adm": "some-test-ad-2",
"crid": "crid_10",
"mtype": 2
}]
}
],
"cur": "USD"
}
}
}
],

"expectedBidResponses": [
{
"bids": [
{
"bid": {
"id": "bid-1",
"impid": "test-imp-id-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"mtype":2
},
"type": "video"
}
]
},
{
"bids": [
{
"bid": {
"id": "bid-2",
"impid": "test-imp-id-2",
"price": 10,
"adm": "some-test-ad-2",
"crid": "crid_10",
"mtype":2
},
"type": "video"
}
]
}
]
}
Loading
Loading