UOE-10243: Support for Applovin Max Request #744
Conversation
… into prebid_upgrade_v2.10.0
…OpenWrap/prebid-server into prebid_upgrade_v2.10.0
…etheus server (#750) * OTT-1697 : Added support to handle /stats and /metrics endpoint on prometheus server
… into prebid_upgrade_v2.10.0
Prebid upgrade v2.10.0
* UOE-10317: Improvdigital bidder support publisherId * test case update * make publisherId mandatory * Update comment
* Added changes for moving vastunwrap module to openwrap module
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adapters/adkernel/adkernel.go
Outdated
| } | ||
| for _, imp := range imps { | ||
| if imp.ID == impID { | ||
| if imp.Banner != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
adapters/adkernel/adkernel.go
Outdated
| if imp.ID == impID { | ||
| if imp.Banner != nil { | ||
| return openrtb_ext.BidTypeBanner | ||
| } else if imp.Video != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
adapters/adkernel/adkernel.go
Outdated
| return openrtb_ext.BidTypeBanner | ||
| } else if imp.Video != nil { | ||
| return openrtb_ext.BidTypeVideo | ||
| } else if imp.Audio != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
adapters/adkernel/adkernel.go
Outdated
| return openrtb_ext.BidTypeVideo | ||
| } else if imp.Audio != nil { | ||
| return openrtb_ext.BidTypeAudio | ||
| } else if imp.Native != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
pm-saurabh-narkhede
force-pushed
the
UOE-10243
branch
from
71b4d50 to
21b7c16
Compare
pm-saurabh-narkhede
force-pushed
the
UOE-10243
branch
from
16adc31 to
96fc655
Compare
No description provided.