UOE:10435 Migrate Wakanda to prebid #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,6 +142,15 @@ func (m OpenWrap) handleEntrypointHook( | |||
| rCtx.PubID = pubid | |||
| } | |||
|
|
|||
| // rCtx.WakandaDebug.EnableIfRequired(rCtx.PubIDStr, rCtx.ProfileIDStr) | |||
| // if rCtx.WakandaDebug.Enabled { | |||
| rCtx.WakandaDebug.DebugData.HTTPRequest = payload.Request | |||
There was a problem hiding this comment.
getAccountIdFromRawRequest
endpoints/openrtb2/auction_ow.go
Outdated
| @@ -81,4 +81,6 @@ func UpdateResponseExtOW(w http.ResponseWriter, bidResponse *openrtb2.BidRespons | |||
| w.WriteHeader(http.StatusNoContent) | |||
| } | |||
| } | |||
| rCtx.WakandaDebug.DebugData.HTTPResponse = w | |||
There was a problem hiding this comment.
why is this required?. Response is already available in ao
Comment on lines
92
to
98
| if rCtx.WakandaDebug.Enabled { | ||
| rCtx.WakandaDebug.DebugData.OpenRTB = payload.BidRequest | ||
| // defer rCtx.WakandaDebug.WriteLogToFiles() /// need to move | ||
| } else { | ||
| rCtx.WakandaDebug.DebugData.HTTPRequest = nil | ||
| rCtx.WakandaDebug.DebugData.HTTPRequestBody = nil | ||
| } |
There was a problem hiding this comment.
this is not needed.
| @@ -88,6 +88,15 @@ func (m OpenWrap) handleBeforeValidationHook( | |||
| rCtx.DeviceCtx.Platform = getDevicePlatform(rCtx, payload.BidRequest) | |||
| populateDeviceContext(&rCtx.DeviceCtx, payload.BidRequest.Device) | |||
|
|
|||
| rCtx.WakandaDebug.EnableIfRequired(rCtx.PubIDStr, rCtx.ProfileIDStr) | |||
There was a problem hiding this comment.
move this to entrypoint hook
Comment on lines
103
to
117
| hbMux := http.NewServeMux() | ||
| hbMux.HandleFunc("/wakanda", wakanda.Handler(cfg.Wakanda)) | ||
| srvInterface := ":" + cfg.Server.Port | ||
| go startServer(srvInterface, hbMux) | ||
| wakanda.InitWakanda(time.Duration(cfg.Wakanda.MaxDuration), time.Duration(cfg.Wakanda.CleanupFrequency)) | ||
| return *ow, nil | ||
| } | ||
|
|
||
| var startServer = func(srvInterface string, hbMux *http.ServeMux) error { | ||
| if err := http.ListenAndServe(srvInterface, hbMux); err != nil { | ||
| logger.Fatal("main.main:unable to start http server: %s", err.Error()) | ||
| return err | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
move this code to separate file server.go
Comment on lines
11
to
24
| HTTPRequest *http.Request | ||
| HTTPRequestBody json.RawMessage | ||
| HTTPResponse http.ResponseWriter | ||
| HTTPResponseBody string | ||
| OpenRTB any | ||
| PrebidHTTPRequest *http.Request | ||
| PrebidRequestBody json.RawMessage | ||
| PrebidHTTPResponse *httptest.ResponseRecorder | ||
| Logger json.RawMessage | ||
| WinningBid bool | ||
| // PartnerMapping | ||
| // AdUnitConfig | ||
| // Logger | ||
| } |
There was a problem hiding this comment.
HTTPRequest will be mapped to request cached in rctx.
HTTPRequestBody will be mapped to request body cached in rctx.
HTTPResponse will be mapped to ao.Response
OpenRTB will be mapped to ao.RequestWrapper
Logger will be mapped to ao.Logger
pm-priyanka-bagade
force-pushed
the
UOE-10435
branch
from
d1ad34d to
8d38608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.