Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-1799: support macros in oRTB bidder endpoint-url #805

Merged
merged 11 commits into from
Jun 12, 2024
Merged

OTT-1799: support macros in oRTB bidder endpoint-url #805

merged 11 commits into from
Jun 12, 2024

Conversation

ashishshinde-pubm
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fd085be

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:40:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:47:		makeRequestForAllImps		94.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:96:		makeRequestPerImp		90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:144:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:163:		MakeRequests			88.2%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:194:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:224:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:244:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:260:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:8:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:23:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:19:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:55:			getNode				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:70:			newBadInputError		100.0%
total:												(statements)			95.7%

@ashishshinde-pubm ashishshinde-pubm changed the title OTT-1799: support for macros in oRTB bidder endpoint-url OTT-1799: support macros in oRTB bidder endpoint-url Jun 3, 2024
@ashishshinde-pubm ashishshinde-pubm marked this pull request as ready for review June 3, 2024 09:50
pm-nikhil-vaidya
pm-nikhil-vaidya requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@pm-nikhil-vaidya pm-nikhil-vaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some commets

Pubmatic-Dhruv-Sonone
Pubmatic-Dhruv-Sonone requested changes Jun 5, 2024
View reviewed changes
adapters/ortbbidder/constant.go Outdated Show resolved Hide resolved
adapters/ortbbidder/ortbbidder.go Outdated Show resolved Hide resolved
adapters/ortbbidder/ortbbidder.go Outdated Show resolved Hide resolved
adapters/ortbbidder/requestParamMapper.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0f8cc85

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:41:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:49:		makeRequest			88.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:130:		appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:148:		buildEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:158:		convertRequestToMap		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:167:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:186:		MakeRequests			88.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:203:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:233:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:253:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:269:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:28:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:44:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:23:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:73:			getNode				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:86:			newBadInputError		100.0%
total:												(statements)			95.2%

Pubmatic-Dhruv-Sonone
Pubmatic-Dhruv-Sonone requested changes Jun 6, 2024
View reviewed changes
adapters/ortbbidder/util.go Outdated Show resolved Hide resolved
adapters/ortbbidder/bidderparams/config.go Outdated Show resolved Hide resolved
adapters/ortbbidder/bidderparams/config.go Outdated Show resolved Hide resolved
Pubmatic-Dhruv-Sonone
Pubmatic-Dhruv-Sonone requested changes Jun 6, 2024
View reviewed changes
adapters/ortbbidder/bidderparams/config.go Outdated Show resolved Hide resolved
adapters/ortbbidder/bidderparams/config.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7db6cea

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:77:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:107:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:127:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:143:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:28:		parseRequest			81.8%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:46:		buildRequestNode		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:55:		buildEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:74:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:92:		makeRequest			88.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:146:	makeRequest			95.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:188:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			95.2%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5cd22dd

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:77:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:107:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:127:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:143:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:28:		parseRequest			81.8%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:46:		buildRequestNode		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:55:		buildEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:74:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:92:		makeRequest			88.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:146:	makeRequest			95.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:188:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			95.2%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, eb685f1

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:16:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:112:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:132:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:148:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:32:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:50:		getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:62:		cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:72:		appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:19:	parseRequest			81.8%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:40:	makeRequest			95.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			93.7%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 475224e

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:16:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:112:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:132:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:148:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:32:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:50:		getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:62:		cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:72:		appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:19:	parseRequest			81.8%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:40:	makeRequest			95.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			93.7%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5e3e429

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:112:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:132:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:148:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:32:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:50:		getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:62:		cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:72:		appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:46:	makeRequest			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			93.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 52dae91

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multiRequestBuilder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:112:		getMediaTypeForBid		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:132:		getMediaTypeForBidFromMType	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:148:		isORTBBidder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:32:		newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:50:		getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:62:		cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestBuilder.go:72:		appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:11:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:31:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestParamMapper.go:47:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/singleRequestBuilder.go:46:	makeRequest			91.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:21:			setValue			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/util.go:71:			getNode				100.0%
total:												(statements)			93.0%

Repository owner deleted a comment from ashishshinde-pubm Jun 12, 2024
pm-viral-vala
pm-viral-vala approved these changes Jun 12, 2024
View reviewed changes
adapters/ortbbidder/bidderparams/config.go Outdated Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Outdated Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Outdated Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Outdated Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Show resolved Hide resolved
adapters/ortbbidder/requestBuilder.go Outdated Show resolved Hide resolved
@pm-viral-vala pm-viral-vala merged commit 857405b into ci Jun 12, 2024
4 checks passed
@ashishshinde-pubm ashishshinde-pubm deleted the OTT-1799 branch June 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvinashKapre AvinashKapre AvinashKapre left review comments

@pm-jaydeep-mohite pm-jaydeep-mohite pm-jaydeep-mohite left review comments

@pm-viral-vala pm-viral-vala pm-viral-vala approved these changes

@pm-nikhil-vaidya pm-nikhil-vaidya pm-nikhil-vaidya left review comments

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone Awaiting requested review from Pubmatic-Dhruv-Sonone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashishshinde-pubm @pm-jaydeep-mohite @pm-viral-vala @Pubmatic-Dhruv-Sonone @pm-nikhil-vaidya @AvinashKapre