OTT-1704: Bidder Response mapping framework for ortb bidder #806

Pubmatic-Dhruv-Sonone · 2024-06-03T17:16:15Z

Description

Ortb bidder response changes
Bidder param resolver framework
Code refactor

Checklist:

PR commit list is unique (rebase/pull with the origin branch to keep master clean).
JIRA number is added in the PR title and the commit message.
Updated the header-bidding repo with appropiate commit id.
Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

adapters/ortbbidder/ortbbidder.go

adapters/ortbbidder/param_mapper.go

adapters/ortbbidder/ortbbidder.go

adapters/ortbbidder/response_builder.go

adapters/ortbbidder/util/util_test.go

adapters/ortbbidder/resolver/bidtype_resolver.go

github-actions · 2024-06-16T15:01:09Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c2d28f5

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	parseResponse			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:38:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:93:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.2%

ashishshinde-pubm

LGTM

ShriprasadM

@Pubmatic-Dhruv-Sonone : There are minor comments.

adapters/ortbbidder/response_builder.go

adapters/ortbbidder/ortbbidder.go

adapters/ortbbidder/resolver/bidtype_resolver.go

adapters/ortbbidder/resolver/param_resolver.go

ShriprasadM

@Pubmatic-Dhruv-Sonone : Please address minor comments. Otherwise LGTM

github-actions · 2024-06-17T06:46:09Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, de38c94

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:90:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.1%

github-actions · 2024-06-17T07:48:54Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, cfd9047

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:90:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.1%

github-actions · 2024-06-17T08:03:38Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 58168e3

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:90:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.1%

github-actions · 2024-06-17T08:11:53Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 583e23f

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:90:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.1%

github-actions · 2024-06-17T08:13:25Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f931f65

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:17:			newBadInputError		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/errors.go:23:			newBadServerResponseError	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:16:	parseRequest			75.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/multi_request_builder.go:43:	makeRequest			82.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:38:		InitBidderParamsConfig		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:44:		Builder				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:63:		MakeRequests			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:82:		MakeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/ortbbidder.go:102:		makeBids			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:50:	getEndpoint			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:62:	cloneRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/request_builder.go:72:	appendRequestData		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:21:	newResponseBuilder		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:30:	setPrebidBidderResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/response_builder.go:90:	buildAdapterResponse		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:19:	parseRequest			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/ortbbidder/single_request_builder.go:46:	makeRequest			91.7%
total:												(statements)			93.1%

Pubmatic-Dhruv-Sonone added 4 commits June 3, 2024 16:21

OTT-1704: Framework to build bid reponse for ortb bidder

afb67ce

Fixing import

f898a5f

OTT-1704: Bidder response framework draf

b825550

renamed file

fa1a6e3

Pubmatic-Dhruv-Sonone requested review from pm-viral-vala and ashishshinde-pubm June 3, 2024 17:16

Pubmatic-Dhruv-Sonone added 3 commits June 3, 2024 22:47

Fixing getValueFromLocation function

4443c51

Refactor param_mapper

97233a0

updating get value from location function

5914f8c

ShriprasadM requested changes Jun 5, 2024

View reviewed changes

adapters/ortbbidder/ortbbidder.go Outdated Show resolved Hide resolved

Pubmatic-Dhruv-Sonone added 2 commits June 6, 2024 12:20

Refactoring

4c2fefc

Merge branch 'ci' into OTT-1704

f7271a5

Pubmatic-Dhruv-Sonone marked this pull request as ready for review June 6, 2024 19:44

Pubmatic-Dhruv-Sonone added 9 commits June 7, 2024 01:20

Refactoring

7d67600

Fixing MType parser

a548369

Adding param resolver

ef55702

resolver draft

c1067b3

Adding util and resolver package

6eeeb55

Refactoring code

c6f9d6c

Adding unit test for resolver package

abd4d63

Adding UT

05ec1a7

Adding unit test

81a9ea8

Pubmatic-Dhruv-Sonone force-pushed the OTT-1704 branch from 369bb9b to 81a9ea8 Compare June 12, 2024 06:33

Pubmatic-Dhruv-Sonone added 6 commits June 12, 2024 12:04

removing commented code

4c3a265

Merging lastest ci and refactoring

d29f544

Adding unit tests and code refactor

c302e97

Fixing unit test and refactorign

8da86d4

Refactoring

d2e1b0a

Unit test refactor

45c645c

Repository owner deleted a comment from github-actions bot Jun 16, 2024

ashishshinde-pubm reviewed Jun 16, 2024

View reviewed changes

adapters/ortbbidder/response_builder.go Show resolved Hide resolved

ashishshinde-pubm reviewed Jun 16, 2024

View reviewed changes

adapters/ortbbidder/util/util_test.go Show resolved Hide resolved

ashishshinde-pubm reviewed Jun 16, 2024

View reviewed changes

adapters/ortbbidder/resolver/bidtype_resolver.go Show resolved Hide resolved

Addressing review comments

c2d28f5

ashishshinde-pubm previously approved these changes Jun 17, 2024

View reviewed changes

ShriprasadM reviewed Jun 17, 2024

View reviewed changes

ShriprasadM previously approved these changes Jun 17, 2024

View reviewed changes

Addressing review comments

de38c94

Pubmatic-Dhruv-Sonone dismissed stale reviews from ShriprasadM and ashishshinde-pubm via de38c94 June 17, 2024 06:45

Fixing response param path

cfd9047

Fixing semgroup check

58168e3

Test

583e23f

test

f931f65

ashishshinde-pubm approved these changes Jun 17, 2024

View reviewed changes

pm-saurabh-narkhede approved these changes Jun 17, 2024

View reviewed changes

Pubmatic-Dhruv-Sonone merged commit 61416e2 into ci Jun 17, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OTT-1704: Bidder Response mapping framework for ortb bidder #806

OTT-1704: Bidder Response mapping framework for ortb bidder #806

Pubmatic-Dhruv-Sonone commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 16, 2024

ashishshinde-pubm left a comment

ShriprasadM left a comment

ShriprasadM left a comment

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

OTT-1704: Bidder Response mapping framework for ortb bidder #806

OTT-1704: Bidder Response mapping framework for ortb bidder #806

Conversation

Pubmatic-Dhruv-Sonone commented Jun 3, 2024 • edited Loading

Description

Checklist:

github-actions bot commented Jun 16, 2024

Code coverage summary

ortbbidder

ashishshinde-pubm left a comment

Choose a reason for hiding this comment

ShriprasadM left a comment

Choose a reason for hiding this comment

ShriprasadM left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 17, 2024

Code coverage summary

ortbbidder

github-actions bot commented Jun 17, 2024

Code coverage summary

ortbbidder

github-actions bot commented Jun 17, 2024

Code coverage summary

ortbbidder

github-actions bot commented Jun 17, 2024

Code coverage summary

ortbbidder

github-actions bot commented Jun 17, 2024

Code coverage summary

ortbbidder

Pubmatic-Dhruv-Sonone commented Jun 3, 2024 •

edited

Loading