Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-1956: Introduce transparency object in response.bid.ext.dsa #871

Merged
merged 4 commits into from
Aug 9, 2024
Merged

OTT-1956: Introduce transparency object in response.bid.ext.dsa #871

merged 4 commits into from
Aug 9, 2024

Conversation

ashishshinde-pubm
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7bd00bb

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:102:	MakeRequests				93.1%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:256:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:299:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:311:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:319:	parseImpressionObject			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:426:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:431:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:496:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:514:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:538:	MakeBids				89.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:628:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:650:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:662:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:675:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:690:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:740:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:753:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:773:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				92.9%

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4ae7b8f

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:102:	MakeRequests				93.1%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:256:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:299:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:311:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:319:	parseImpressionObject			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:426:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:431:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:496:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:514:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:538:	MakeBids				89.4%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:628:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:650:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:662:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:675:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:690:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:740:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:753:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:773:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				92.9%

pm-saurabh-narkhede
pm-saurabh-narkhede approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@pm-saurabh-narkhede pm-saurabh-narkhede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Just consider we get minimum conflicts while doing next prebid upgrade.

@pm-isha-bharti
Copy link
Collaborator

Added minor comment rest LGTM

ShriprasadM
ShriprasadM approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@ShriprasadM ShriprasadM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let us ensure that we are adding the details on the ticket.

adapters/pubmatic/pubmatic_ow.go Show resolved Hide resolved
@ashishshinde-pubm ashishshinde-pubm merged commit 7b3c275 into ci Aug 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-saurabh-narkhede pm-saurabh-narkhede pm-saurabh-narkhede approved these changes

@ShriprasadM ShriprasadM ShriprasadM approved these changes

@pm-isha-bharti pm-isha-bharti pm-isha-bharti approved these changes

@pm-viral-vala pm-viral-vala Awaiting requested review from pm-viral-vala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashishshinde-pubm @pm-isha-bharti @ShriprasadM @pm-viral-vala @pm-saurabh-narkhede