Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp #935

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

AvinashKapre
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Oct 8, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 07d0760

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:109:	MakeRequests				96.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:265:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:303:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:326:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:369:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:381:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:389:	parseImpressionObject			93.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:507:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:512:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:577:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:595:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:619:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:710:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:714:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:736:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:748:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:761:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:776:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:826:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:839:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:859:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:867:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.2%

Copy link

github-actions bot commented Oct 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3453bed

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:109:	MakeRequests				96.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:265:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:303:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:326:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:369:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:381:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:389:	parseImpressionObject			93.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:507:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:512:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:577:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:595:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:619:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:710:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:714:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:736:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:748:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:761:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:776:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:826:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:839:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:859:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:867:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.2%

Copy link

github-actions bot commented Oct 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b0c7fe5

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:109:	MakeRequests				96.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:265:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:303:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:326:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:369:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:381:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:389:	parseImpressionObject			93.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:507:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:512:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:577:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:595:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:619:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:710:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:714:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:736:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:748:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:761:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:776:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:826:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:839:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:859:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:867:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.2%

Copy link

github-actions bot commented Oct 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f971d9b

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:109:	MakeRequests				96.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:264:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:302:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:325:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:368:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:380:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:388:	parseImpressionObject			93.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:506:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:511:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:576:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:594:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:618:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:709:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:713:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:735:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:747:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:760:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:775:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:825:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:838:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:858:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:867:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.2%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 07981d2

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:109:	MakeRequests				95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:267:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:305:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:328:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:371:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:383:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:391:	parseImpressionObject			93.5%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:509:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:514:	extractPubmaticExtFromRequest		94.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:579:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:597:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:621:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:712:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:716:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:738:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:750:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:763:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:778:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:828:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:841:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:861:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:870:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.0%

@pm-isha-bharti pm-isha-bharti merged commit 07dac81 into ci Oct 10, 2024
4 checks passed
Pubmatic-Dhruv-Sonone added a commit that referenced this pull request Oct 16, 2024
* UOE-11191: Refactor: consume StoreURL from New portal UI and forward appstoreurl and appsource for applovinmax (#925)

* UOE-11191: Refactor: consume StoreURL from New portal UI and forward appstoreurl and appsource for applovinmax

* review comment

* UOE-11185: Stats for parsing failed for ituneid

* go fmt update

* OTT-1807-P1: discard emptyVAST and invalidVAST bids detected by VAST unwrap module (#933)

Co-authored-by: ashishshinde-pubm <[email protected]>
Co-authored-by: supriya-patil <[email protected]>
Co-authored-by: dhruv.sonone <[email protected]>

* UOE-11098: Pass user.ext.sessionduration and user.ext.impdepth ORTB request to OW partners (#922)

* UOE-11168: Consume then Remove `app.id` from ApplovinMax Request (#931)

* UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp (#935)

* UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp

* test case name update

* comment

* review comment

* UOE-11355: bug fix- AppLovinMax: sendburl is getting passed at imp.ext instead of req.ext (#940)

* UOE-11310: ApplovinMax Signal data not visible in the wakanda logs (#936)

* UOE-11326: Multiimpression request not logger in case one of the bid is rejected because of invalid mapping (#937)

* UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S (#941)

* UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S

* test cases

* comment

* review comment

* pip install fix

* Fixing semgrp

* Semgrep fix

* Semgrep fix

* Changing ubuntu version

---------

Co-authored-by: PubMatic-OpenWrap <[email protected]>
Co-authored-by: pm-avinash-kapre <[email protected]>
Co-authored-by: Viral Vala <[email protected]>
Co-authored-by: ashishshinde-pubm <[email protected]>
Co-authored-by: supriya-patil <[email protected]>
Co-authored-by: Pubmatic-Supriya-Patil <[email protected]>
Co-authored-by: Saurabh Narkhede <[email protected]>
Co-authored-by: pm-priyanka-bagade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants