2512 PufferWithdrawalManager #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9inpachi
requested changes
Sep 18, 2024
|
|
||
| /** | ||
| * Request a withdrawal of the given amount to the given address, with a permit. | ||
| * @param walletAddress The account address to request the withdrawal for. |
There was a problem hiding this comment.
Would be good if we could leave a space between the param and the description to make it more readable.
| * @returns The transaction hash of the withdrawal. | ||
| */ | ||
| public async requestWithdrawal(walletAddress: Address, amount: bigint) { | ||
| return await this.getContract().write.requestWithdrawal( |
There was a problem hiding this comment.
As a general practice across the SDK, the write functions should return transact and estimate so they SDK consumers can estimate gas if they need to.
| getContract: jest.fn(), | ||
| })); | ||
| jest.mock('./erc20-permit-handler'); | ||
| const mockErc20PermitHandler = jest.mocked(ERC20PermitHandler); |
There was a problem hiding this comment.
9inpachi
approved these changes
Sep 18, 2024
| walletAddress: Address, | ||
| withdrawalIdx: bigint, | ||
| ) { | ||
| return await this.getContract().write.completeQueuedWithdrawal( |
There was a problem hiding this comment.
This also needs the transact and estimate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing functionality of the 2-step withdrawal manager in the SDK.
These are the likely usable functions, but we can add more later.
Not testable yet since various aspects are still WIP on the smartcontract side.