Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(convert): add file_map table to return correct hash, and jacket conversion task #41

Merged
merged 11 commits into from
Jul 2, 2022
Merged

feat(convert): add file_map table to return correct hash, and jacket conversion task #41

merged 11 commits into from
Jul 2, 2022

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Jun 15, 2022 •
edited by Dosugamea
Loading

概要 / Overview

譜面変換後のSHA1ハッシュ値が実際と異なる問題の修正用の処理追加と ジャケットを変換するための sonolus-image-serverの バックグラウンドタスクを追加しました。 また、テストコードの追加と若干の修正をしました。

実装内容(できること) / Implementation details

  • 譜面変換後に変えるファイルのハッシュ値が 実際と異なっていた問題を解消するため 変換テーブルを追加
    • file_mapテーブルで 変換前と変換後のハッシュの翻訳を行うように
  • ジャケット画像変換タスクの追加
    • 変換処理はすぐには終わらないため、 get_first_item_wait_or_404関数を追加し 処理が終わるまで待てるように
  • テストコードの管理者名 固定値の変更
    • より一般的な単語である admin を使うように
  • prefix変換のテストコード追加
    • Sonolus 0.6.0用のサーバーprefixを外す処理が正しくできているかテスト
  • ローカルでテストができないため Firebase Auth Emulatorの追加

副作用(できなくなったこと) / Side effects (Removed features)

  • FIREBASE_AUTH_EMULATORを再使用します

関連Issue / Related issues

#14 #21 #25
Closes #40

参考 / References

  • Discord側 #甘芋開発 チャンネル 2022/06 付近参照

@sevenc-nanashi sevenc-nanashi changed the title [WIP] Improve conversion [WIP] file_map + image conversion task Jun 16, 2022
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review June 18, 2022 14:29
@sevenc-nanashi
Copy link
Member Author

Closes: #40

@sevenc-nanashi sevenc-nanashi marked this pull request as draft June 18, 2022 14:40
@sevenc-nanashi
Copy link
Member Author

移行コードのことを完全に忘れていた

@Dosugamea Dosugamea self-requested a review June 28, 2022 10:44
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review June 29, 2022 13:33
@sevenc-nanashi sevenc-nanashi changed the title [WIP] file_map + image conversion task file_map + image conversion task Jun 29, 2022
@Dosugamea Dosugamea changed the title file_map + image conversion task feat(convert): add file_map table to return correct hash, and jacket conversion task Jun 29, 2022
Dosugamea
Dosugamea requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Dosugamea Dosugamea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たぶん同じテーブルを2回作っちゃってるので それまとめてほしいのと、
pathmagicの意図かるく知りたいっす

.env_example Show resolved Hide resolved
alembic/versions/48db6963ab56_recreate_file_maps.py Outdated Show resolved Hide resolved
tests/_pathmagic.py Show resolved Hide resolved
@Dosugamea Dosugamea added [Priority] middle 🍨 This is NEEDED, but do later [Type] improve feature🌟 Improve feature or small change labels Jun 29, 2022
@Dosugamea Dosugamea self-assigned this Jun 29, 2022
@Dosugamea Dosugamea linked an issue Jun 29, 2022 that may be closed by this pull request
ジャケット画像調整用外部APIの連携 #14
Open
@Dosugamea Dosugamea removed a link to an issue Jun 29, 2022
ジャケット画像調整用外部APIの連携 #14
Open
Dosugamea
Dosugamea approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@Dosugamea Dosugamea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います コントリビュートありがとうございます

@Dosugamea Dosugamea merged commit 7ecfd3c into PurplePalette:develop Jul 2, 2022
@Dosugamea Dosugamea mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosugamea Dosugamea Dosugamea approved these changes

Assignees

@Dosugamea Dosugamea

@sevenc-nanashi sevenc-nanashi

Labels
[Priority] middle 🍨 This is NEEDED, but do later [Type] improve feature🌟 Improve feature or small change
Projects
SweetPotato3をローンチしたい
Status: Done
Milestone
とりあえずきちんと譜面配信ができる状態に
2 participants
@sevenc-nanashi @Dosugamea