-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ffmpeg 6.1 #1252
Upgrade to ffmpeg 6.1 #1252
Conversation
5bec1be
to
5cd3ac4
Compare
This PR does not do what it says: it is also dropping all tests against FFmpeg 5.0, why? |
Please do NOT merge until you have answered my question. |
|
This is an odd comment. This commit tests with 6.1 and will ship the ffmpeg 6.1 binaries instead of the 6.0 binaries when it's released on PyPI. |
My point is that PRs and commit messages need to actually describe what they are doing: this one adds tests against FFmpeg 6.1 (good), but also drops tests against FFmpeg 5.0 - which we say we still support (not good). Either we still support FFmpeg 5.0, in which case we keep testing against it or we officially abandon support FFmpeg 5.0. I'm not adverse to dropping FFmpeg 5.0 but this needs to be reflected both in the commit message and the documentation ( FFmpeg minor versions can also introduce new APIs or deprecate old ones: I think this is exactly what happens with FFmpeg 5.1, I noticed we're getting compilation warnings specifically in FFmpeg 5.1 and up |
Okay, I've restored all ffmpeg 5.0 and 5.1 tests. |
No description provided.