Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPI trusted publishing #420

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Switch to PyPI trusted publishing #420

merged 1 commit into from
Oct 13, 2023

Conversation

AlexWaygood
Copy link
Collaborator

Doing this means we can remove the long-lived PYPI_API_TOKEN from this repo, which improves security. See https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/ for more details.

@JelleZijlstra let me know once you've enabled this on PyPI! (We can't merge this until that's done.)

N.B. I'm also bumping pre-commit-hooks here -- I did this for our pyproject.toml file in #419, but forgot to update the same pin in our .pre-commit-config.yaml file. Doesn't feel like it deserves its own PR :p

@github-actions
Copy link

This change has no effect on typeshed. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it on PyPI!

@AlexWaygood AlexWaygood marked this pull request as ready for review October 13, 2023 06:21
@AlexWaygood AlexWaygood merged commit e25f15f into main Oct 13, 2023
@AlexWaygood AlexWaygood deleted the trusted-publishing branch October 13, 2023 06:22
@AlexWaygood
Copy link
Collaborator Author

I just released 23.10.0 using trusted publishing, and it worked like a charm 🥳 https://pypi.org/project/flake8-pyi/23.10.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants