-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new type error #489
Fix new type error #489
Conversation
python/typeshed#11880 correctly points out that not all AST nodes have a line and column number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a protocol would be a better fit here? Any node will do as long as it has a lineno and col_offset
This comment has been minimized.
This comment has been minimized.
It might even be worthwhile to add such a protocol to typeshed, considering that this will be a fairly common use case. |
Yeah — or perhaps But for now I think we could just roll our own |
This change has no effect on typeshed. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
python/typeshed#11880 correctly points out that not all AST nodes have a line and column number.