Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back list() when iterating over d.items() in a for statement #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add back list() when iterating over d.items() in a for statement #262

wants to merge 1 commit into from

Commits on Oct 11, 2023

  1. Revert "Fix transformation of non-iter dict methods in for loops" 

    This reverts commit 8a1ef24.

It is often incorrect to omit the list() when converting for x in d.items() to python3 because if you omit list(), then adding or removing elements while iterating will raise RuntimeError: dictionary changed size during iteration.
    @yonran
    yonran committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fd2841f View commit details
    Browse the repository at this point in the history