Fix grammar and phrasing #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very first sentence is quite an awkward english to me; I've asked claude and chatgpt and they both agree its not optimal.
ikamensh
commented
Aug 25, 2024
Comment on lines
+8
to
+9
| "RedBaron is a Python library and tool powerful enough to be used in IPython. | ||
| It aims to make the process of writing code that modifies source code as easy and simple as possible." That includes writing custom |
There was a problem hiding this comment.
Suggested change
| "RedBaron is a Python library and tool powerful enough to be used in IPython. | |
| It aims to make the process of writing code that modifies source code as easy and simple as possible." That includes writing custom | |
| "RedBaron is a Python library designed to be used with IPython. | |
| It aims to make the process of writing code that modifies source code as easy and simple as possible." That includes writing custom |
This was trying to be as close to original as possible. At the same time it now seems that first sentence tells nothing in particular except association with IPython. Is RedBaron designed to work best with IPython?
| solely that intent to make the process of **writing code that modify source | ||
| code** as easy and as simple as possible. That include writing custom | ||
| "RedBaron is a Python library and tool powerful enough to be used in IPython. | ||
| It aims to make the process of writing code that modifies source code as easy and simple as possible." That includes writing custom | ||
| refactoring, generic refactoring, tools, IDE or directly modifying you source |
There was a problem hiding this comment.
what is the difference of custom and generic refactoring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very first sentence is quite an awkward english to me, peaking with "solely that intent"; I've asked claude and chatgpt and they both agree its not optimal.
My suggested phrasing might not tell exactly what you wanted to tell though because I don't know enough about RedBaron.