Add sync #18
Open
Add sync #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
woile
reviewed
Apr 2, 2024
| @@ -39,6 +40,10 @@ def cli() -> argparse.Namespace: | |||
| ) | |||
| categorize_parser.set_defaults(func=categorize) | |||
|
|
|||
| # Subparser for the sync command | |||
| categorize_parser = subparsers.add_parser("sync", help="Report transactions") | |||
There was a problem hiding this comment.
I would call the command "sink" with help: "send or store the results to the chosen sink" or something like that
fabridamicelli
requested changes
Apr 2, 2024
| @@ -138,13 +143,25 @@ def categorize(engine): | |||
| print("Session interrupted. Closing.") | |||
|
|
|||
|
|
|||
| def sync(args, engine): | |||
There was a problem hiding this comment.
I also find "sync" a bit confusing for this functionality. I would go for something more in the direction of "print-summary".
So that can later be the 1st step in exporting to a sink or a making a true synchronization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the example I showed the last day. also some small fix