Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use install-action to download cargo-codspeed binary #3534

Closed
wants to merge 1 commit into from
Closed

ci: use install-action to download cargo-codspeed binary #3534

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Member

Should cut the benchmarks job time by ~5 minutes (as well as reduce the build cache size).

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Oct 20, 2023
@davidhewitt davidhewitt marked this pull request as draft October 20, 2023 12:12
@davidhewitt
Copy link
Member Author

Looks like the prebuilt download failed, will retry after CodSpeedHQ/codspeed-rust#24

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #3534 will not alter performance

Comparing davidhewitt:binstall-codspeed (1dca5b1) with main (abe518d)

Summary

✅ 63 untouched benchmarks

@davidhewitt
Copy link
Member Author

Still nope; CodSpeedHQ/codspeed-rust#27

@davidhewitt
Copy link
Member Author

This got done in #4430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidhewitt