Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the use of PyCell in favor of Bound and Py #3916

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Feb 29, 2024

Part of #3684, following #3914 (review)

This deprecates PyCell in favor of Bound and Py.

For most of the implementation I just added #[allow(deprecated)], so there might so still some opportunity for refactoring. The tests I have adjusted to the new API.

Edit: I marked this as draft, since it depends on #3914

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Feb 29, 2024
@Icxolu Icxolu force-pushed the pycell-deprecation branch 2 times, most recently from f3f21df to 3a0e958 Compare February 29, 2024 19:32
@Icxolu Icxolu marked this pull request as draft February 29, 2024 19:32
@Icxolu
Copy link
Contributor Author

Icxolu commented Mar 1, 2024

I have rebased this, but maybe it makes sense to land this after #3917

@Icxolu Icxolu marked this pull request as ready for review March 1, 2024 19:04
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks great, thanks as always. Had just a few small thoughts.

Regarding the ordering, I guess if I get #3917 merged first then it'll be possible to get a lot of the implementation migrated without the deprecation allows going everywhere. I'll try and complete that in a moment...

src/conversion.rs Outdated Show resolved Hide resolved
src/pycell.rs Outdated Show resolved Hide resolved
tests/test_class_new.rs Show resolved Hide resolved
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great following the rebase, thanks again!

@davidhewitt davidhewitt added this pull request to the merge queue Mar 3, 2024
Merged via the queue into PyO3:main with commit 70a7aa8 Mar 3, 2024
41 of 42 checks passed
@Icxolu Icxolu deleted the pycell-deprecation branch March 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants