Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicate test code #3926

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Delete duplicate test code #3926

merged 1 commit into from
Mar 2, 2024

Conversation

LilyFoote
Copy link
Contributor

@LilyFoote LilyFoote commented Mar 2, 2024 •
edited
Loading

These used to explicitly call .iter(), but that was removed in b65cbb9 to resolve lint warnings.

@LilyFoote
Delete duplicate test code
2941bdb 
These used to explicitly call `.iter()`, but that was removed in b65cbb9
to remove lints.
@LilyFoote LilyFoote self-assigned this Mar 2, 2024
@LilyFoote LilyFoote added the CI-skip-changelog Skip checking changelog entry label Mar 2, 2024
davidhewitt
davidhewitt approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, always great to see cleanups like this!

@davidhewitt davidhewitt added this pull request to the merge queue Mar 2, 2024
Merged via the queue into PyO3:main with commit d948277 Mar 2, 2024
43 of 44 checks passed
@LilyFoote LilyFoote deleted the tidy-tests branch March 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@LilyFoote LilyFoote

Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilyFoote @davidhewitt