emit rustc-check-cfg only on rust 1.80+ #4168
Conversation
davidhewitt
force-pushed
the
check-cfg-1.63
branch
from
65c5ee4
to
d8f7aef
Compare
There was a problem hiding this comment.
Makes sense. I thought I tested it when i added them in #4163, and didn't see anything. But I can reproduce this as well (and there also in the CI log), so I guess I'm misremembering or something 🤷 . Given that we now check the rustc version we can maybe also switch to the cargo:: (double colon) variant, which is preferred since 1.77.
|
Ah, looks like cargo explicitly rejects that due to the lower msrv. I guess I'll drop that second commit and merge? |
pyo3-build-config/src/lib.rs
Outdated
| } | ||
| pieces.next()?.parse().ok() | ||
| }) | ||
| .clone() |
There was a problem hiding this comment.
Clippy also appears to be unhappy about this clone call:
As a short-team solution yes, but I think Cargo is a bit overzealous here as they statically second-guess code which can adjust itself at runtime. Will the old format ever be phased out? What if the range between the current version and our MSRV saddles that release and we have to dynamically adjust? |
|
Agreed, I asked about this in rust-lang/cargo#13868 (comment) |
davidhewitt
force-pushed
the
check-cfg-1.63
branch
from
364a311
to
d8f7aef
Compare
davidhewitt
force-pushed
the
check-cfg-1.63
branch
from
d8f7aef
to
cb65548
Compare
Testing on MSRV just now I got a lot of build warnings on the console:
... so I guess let's gate these behind a version check.