Fix lib_dir when cross compiling
#4389
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Oct 11, 2024
Thalyum
force-pushed
the
fix/cross-compile-libdir
branch
from
49dbfab
to
d604061
Compare
|
I will rebase and follow the required steps for contributing |
Thalyum
force-pushed
the
fix/cross-compile-libdir
branch
from
d604061
to
3060d24
Compare
Thalyum
changed the title
lib_dir when cross compilinglib_dir when cross compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests a fix for #4350 , where a linker option was incorrect when cross-compiling. Change a bit the creation of the
InterpreterConfigin case of cross compilation inpyo3-build-config, to take the value ofPYO3_CROSS_LIB_DIRin priority if set, instead of the value provided by the sysconfigdata.Ref: (#4350)