Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace a use of libc::c_void with the std version #4572

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Replace a use of libc::c_void with the std version #4572

merged 1 commit into from
Sep 21, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Sep 21, 2024

No description provided.

@alex alex added the CI-skip-changelog Skip checking changelog entry label Sep 21, 2024
davidhewitt
davidhewitt approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In the future after an msrv bump (I forget which) we can even use std::ffi imports 😁

@davidhewitt davidhewitt added this pull request to the merge queue Sep 21, 2024
Merged via the queue into PyO3:main with commit df07100 Sep 21, 2024
44 checks passed
@alex alex deleted the libc-void branch September 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @davidhewitt