release: 0.22.4 #4575
Merged
release: 0.22.4 #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix case of gil-refs feature breaking `create_exception!` macro * remove `AsPyPointer` on non-gil-refs
|
NB after release I think I will yank 0.22.0 though 0.22.3 due to the |
|
Probably we should file a rustsec advisory as well.
…On Fri, Oct 4, 2024 at 7:50 AM David Hewitt ***@***.***> wrote:
NB after release I think I will yank 0.22.0 though 0.22.3 due to the
PyWeakrefMethods possible use-after-free. The trait was introduced in
0.22.0
—
Reply to this email directly, view it on GitHub
<#4575 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBAE5ROJY44QIY3H2XLZZ2FHTAVCNFSM6AAAAABOW6EQQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTGYZTKMBSGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
…4590) * Add PyWeakref_GetRef and use it in weakref wrappers. (#4528) * deprecate weakref methods that return borrowed references --------- Co-authored-by: Nathan Goldbaum <[email protected]>
davidhewitt
force-pushed
the
release-0.22.4
branch
from
defa520
to
73b061b
Compare
* ci: fix more ubuntu-24.04 failures * use 22.04 to test 3.7 * disable zoneinfo test on free-threading
davidhewitt
added
the
CI-no-fail-fast
* fix garbage collection in inheritance cases * clippy fixes * more clippy fixups * newsfragment * use `get_slot` helper for reading slots * fixup abi3 case * fix new `to_object` deprecation warnings * fix MSRV build
|
Ok, I believe this now has everything I want to see fixed. Assuming CI is green, and I hear no reason to wait, I'll put this live tomorrow and get on with yanking / filing the RustSec advisory. |
|
The crates.io release is live and the older 0.22 versions yanked. I will try to find time later for the advisory and the gh release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding pen for a final set of bug fixes to land on 0.22 branch.
I think we need to merge and cherry pick:
unsafe_codetrigger #4574PyWeakRefMethods::upgrade_borrowed#4590create_exception!macro #4589