Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve center_frequency accuracy, fix edge case #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OverLordGoldDragon
Copy link

@OverLordGoldDragon OverLordGoldDragon commented Oct 14, 2020

Details. In summary, below are addressed:

  1. Failure to estimate center frequency within two significant figures
  2. Using negative frequency index if wavelet's peak frequency is positive max for even len(psi)
  3. Added comments explaining steps

Two sig figs should be bare minimum in precise frequency applications. Case (2) should be rare, but more importantly, it fails to make sense, unless I'm missing something.

In summary, below are addressed:

 1. Failure to estimate center frequency within two significant figures
 2. Using _negative_ frequency index if wavelet's peak frequency is positive max for even `len(psi)`

Two sig figs should be bare minimum in precise frequency applications. Case (2) should be rare, but more importantly, it fails to make sense, unless I'm missing something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant