Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evently bugs #2480

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Evently bugs #2480

merged 3 commits into from
Aug 2, 2024

Conversation

Raviramnani1
Copy link
Collaborator

Description

Added check for max ticket 1000 in price_screen
Added time validation in details_screen
solved error of 13 pixel overflown in Thumbnail section in overview_screen

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MikeSofaer
Copy link
Collaborator

This text should be in i18n but that's not the issue here.

@MikeSofaer MikeSofaer merged commit 7f22b54 into feat/implementEvently Aug 2, 2024
21 of 26 checks passed
@MikeSofaer MikeSofaer deleted the evently-bugs- branch August 2, 2024 18:42
@zube zube bot removed the [zube]: Done label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants