Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap 5 multiselect test #125

Merged
merged 24 commits into from
Nov 14, 2023
Merged

Fix bootstrap 5 multiselect test #125

merged 24 commits into from
Nov 14, 2023

Conversation

delijati
Copy link
Contributor

There is an error in the test.py is uses still the old name for panels and not cards

@stevepiercy
Copy link
Member

@delijati
Copy link
Contributor Author

There's another test failure: https://github.com/Pylons/deformdemo/actions/runs/6868884941/job/18680476654?pr=125#step:7:212.

No, it is supposed to fail as it runs against the old deform main branch aka boostrap3 (in bootstrap3 are "panels" used in boostrap5 "cards")

@stevepiercy
Copy link
Member

Ah, yes, the old chicken-and-egg thing between deform and deformdemo. I'll merge this, then rerun the CI in deform, and see what happens over there.

@stevepiercy stevepiercy merged commit 7e61a76 into Pylons:main Nov 14, 2023
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants