Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add register_routes #121

Merged
merged 2 commits into from
Mar 24, 2021
Merged

add register_routes #121

merged 2 commits into from
Mar 24, 2021

Conversation

gjo
Copy link
Contributor

@gjo gjo commented Mar 13, 2021

Add config directive pyramid_openapi3_register_routes which registers routes from Open API Schema's x-pyramid-route-name extensions.

Refs #46

@zupo
Copy link
Collaborator

zupo commented Mar 13, 2021

Looks good, please add a few lines of documentation for this to Advanced Configuration section of the README.md.

@zupo
Copy link
Collaborator

zupo commented Mar 23, 2021

Hey @gjo, are you still interested in getting this PR merged? I'd really love a sentence or two about why this is needed and how to use it.

Additionally, tests on Python 3.7 seem to be failing on CI. Do they pass on your local machine?

@gjo
Copy link
Contributor Author

gjo commented Mar 24, 2021

tests are works for me on 37, 38, and 39.

@zupo zupo merged commit e03e5cd into Pylons:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants