New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate AcceptLanguageXXXHeader classes into the single AcceptLanguage class #463

Open

mmerickel wants to merge 1 commit into simplify-accept-encoding-parsing from simplify-accept-language-parsing

Member

mmerickel commented Mar 3, 2024 •

edited

Loading

Ensure AcceptLanguage instances are immutable.
Merge missing/invalid/valid into the single instance - there were very very minor differences between the classes.
Delete deprecated __iter__, best_match, quality.
Un-deprecate __contains__ and implement it using basic_filtering.
Modify basic_filtering to consider all tags as matching if the header is invalid/missing.

mmerickel force-pushed the simplify-accept-language-parsing branch from 85f85c9 to 7481fd5 Compare

March 3, 2024 06:04

mmerickel marked this pull request as ready for review

March 3, 2024 06:04

mmerickel force-pushed the simplify-accept-language-parsing branch from 7481fd5 to 27394cf Compare

March 3, 2024 06:47

mmerickel force-pushed the simplify-accept-encoding-parsing branch from d19faa7 to 50f6669 Compare

March 4, 2024 01:04


          consolidate AcceptLanguageXXXHeader classes into the single AcceptLan…

eaa36fa

…guage class

mmerickel force-pushed the simplify-accept-language-parsing branch from 27394cf to eaa36fa Compare

March 4, 2024 01:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet