Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prox approx 6 #467

Merged
merged 19 commits into from
Jan 25, 2025
Merged

Prox approx 6 #467

merged 19 commits into from
Jan 25, 2025
+81 −19

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Dec 2, 2024

No description provided.

@bknueven bknueven mentioned this pull request Dec 2, 2024
Merged
@bknueven
Copy link
Collaborator Author

I think this should be merged, but I'm a bit concerned that there's an assumption in add_initial_cuts_var that xbar == 0.

@bknueven
Copy link
Collaborator Author

I think this should be merged, but I'm a bit concerned that there's an assumption in add_initial_cuts_var that xbar == 0.

Actually, the assumption is xbar == xhat, which is fine for this code because we only get to it if | xbar - xhat | < tolerance.

@bknueven bknueven marked this pull request as ready for review January 24, 2025 18:15
@DLWoodruff DLWoodruff self-requested a review January 24, 2025 21:37
@bknueven bknueven enabled auto-merge January 25, 2025 16:16
@bknueven bknueven merged commit 85d1bff into Pyomo:main Jan 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLWoodruff DLWoodruff DLWoodruff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @DLWoodruff