Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure prox_approx does not loop forever #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make sure prox_approx does not loop forever #477

wants to merge 1 commit into from
+5 −4

Conversation

bknueven
Copy link
Collaborator

Drive by: tee all ranks because we say we're tee-ing all ranks. The caller can control who has tee=True

@bknueven bknueven requested a review from DLWoodruff January 10, 2025 19:40
DLWoodruff
DLWoodruff approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@DLWoodruff DLWoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is urgent, you should merge it; however, hard-wiring 10 Newton steps seems a little uncool. What about users, who, for whatever reason, happen to be missing a finger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLWoodruff DLWoodruff DLWoodruff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @DLWoodruff