Update requirements in preparation for 3.12 #271
Conversation
Prepare for 3.12, fix things, etc etc, inb4 this ruins everything
|
questionary 2.0.1 depends on prompt_toolkit<=3.0.36 and >=2.0, whoops. |
|
The regression in prompt_toolkit can be traced to tmbo/questionary#270.
|
|
First and foremost, thank you very much for your contribution. Speaking of version changes, I suggest introducing modifications to pilot/utils/utils.py in this PR. The current version used by distro is 1.8.0. The usage of Also, considering dependency management is a tricky issue, I recommend introducing a dependency management tool like Poetry to handle it. For instance, using poetry update can update the versions of the packages being used. |
distro.name(pretty=False)
Return the name of the current OS distribution, as a human-readable string.
If pretty is false, the name is returned without version or codename. (e.g. “CentOS Linux”)
If pretty is true, the version and codename are appended. (e.g. “CentOS Linux 7.1.1503 (Core)”)
Should now match current recommendations. |
|
You may also want to update the Also the tests for Linux should be able to run again |
|
Same test failure as main, not pr related. |
|
@nalbion ready for testing/merge 👍 |
There was a problem hiding this comment.
Thanks for doing this! 🙏
Current main works with 3.12 (as psycopg2 was upgraded in another PR). I agree it would be good to update the other packages as well (what this PR does), except maybe bumping the major version for questionary.
I've added a few comments inline.
|
@senko Updated as per your comments 👍 |
|
Hey @CRD716 I've just rebased and merged your changes in 36e5d6a. There were some merge conflicts which I resolved. We've also switched to working in development branch and periodically merging to Thanks for your contribution! 🙏 |
Prepare for 3.12, fix things, etc etc, (inb4 this ruins everything)
I have specifically only updated to versions with no breaking changes, in some cases (ex. urllib3) the version I have selected is extremely out of date, but I wanted to be conservative in my updating.
Links to all not fully updated dependencies' changelogs, ordered by how out of date they still are:
Based on some of the changelogs I've read, this could also increase performance in some areas.