Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and pin MystBin dependencies #45

Merged
merged 4 commits into from
May 22, 2024
Merged

Cleanup and pin MystBin dependencies #45

merged 4 commits into from
May 22, 2024

Conversation

AbstractUmbra
Copy link
Collaborator

Description

This PR cleans up the Python dependencies and also pins them to versions. Currently this is exact pinning which will help cache the build artifacts correctly.

I removed the pyyaml dependency as it was not used in the codebase, and I also removed the humanize dependency as it was used in a single place, with which I replaced with a handwritten util.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

LostLuma
LostLuma previously approved these changes May 22, 2024
core/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Lilly Rose Berner <[email protected]>
@AbstractUmbra AbstractUmbra merged commit e2f92b8 into main May 22, 2024
2 checks passed
@AbstractUmbra AbstractUmbra deleted the fix/pinning branch May 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants