Skip to content

Commit

Permalink
Updates based on review comments (#49)
Browse files Browse the repository at this point in the history
This updates the ZSA ZIPs based on the comments made on PR#680.
  • Loading branch information
vivek-arte authored Jan 5, 2024
1 parent 668312d commit ba1c185
Show file tree
Hide file tree
Showing 6 changed files with 120 additions and 220 deletions.
2 changes: 1 addition & 1 deletion zip-0226.html
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
<span class="math">\(\mathsf{AssetBase} : \mathbb{P}^*\)</span>
is the unique element of the Pallas group <a id="footnote-reference-22" class="footnote_reference" href="#protocol-pallasandvesta">22</a> that identifies each Asset in the Orchard protocol, defined as the Asset Base in ZIP 227 <a id="footnote-reference-23" class="footnote_reference" href="#zip-0227">6</a>, a valid group element that is not the identity and is not
<span class="math">\(\bot\)</span>
. The byte representation of the Asset Base is defined as
. The byte encoding of the Asset Base is defined as
<span class="math">\(\mathsf{asset\_base} : \mathbb{B}^{[\ell_{\mathbb{P}}]} := \mathsf{repr}_{\mathbb{P}}(\mathsf{AssetBase})\)</span>
.</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion zip-0226.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Let :math:`\mathsf{Note^{OrchardZSA}}` be the type of a ZSA note, i.e.
An Orchard ZSA note differs from an Orchard note [#protocol-notes]_ by additionally including the Asset Base, :math:`\mathsf{AssetBase}`. So a ZSA note is a tuple :math:`(\mathsf{g_d, pk_d, v, \rho, \psi, \mathsf{AssetBase}})`,
where

- :math:`\mathsf{AssetBase} : \mathbb{P}^*` is the unique element of the Pallas group [#protocol-pallasandvesta]_ that identifies each Asset in the Orchard protocol, defined as the Asset Base in ZIP 227 [#zip-0227]_, a valid group element that is not the identity and is not :math:`\bot`. The byte representation of the Asset Base is defined as :math:`\mathsf{asset\_base} : \mathbb{B}^{[\ell_{\mathbb{P}}]} := \mathsf{repr}_{\mathbb{P}}(\mathsf{AssetBase})`.
- :math:`\mathsf{AssetBase} : \mathbb{P}^*` is the unique element of the Pallas group [#protocol-pallasandvesta]_ that identifies each Asset in the Orchard protocol, defined as the Asset Base in ZIP 227 [#zip-0227]_, a valid group element that is not the identity and is not :math:`\bot`. The byte encoding of the Asset Base is defined as :math:`\mathsf{asset\_base} : \mathbb{B}^{[\ell_{\mathbb{P}}]} := \mathsf{repr}_{\mathbb{P}}(\mathsf{AssetBase})`.

Note that the above assumes a canonical encoding, which is true for the Pallas group, but may not hold for future shielded protocols.

Expand Down
Loading

0 comments on commit ba1c185

Please sign in to comment.