Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed calculate_linear_dependency_ordering() and bump versions to QEDcore 0.2 and QEDbase 0.3 #83

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the QEDcore package from 0.1 to 0.1, 0.2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@SimeonEhrig SimeonEhrig force-pushed the compathelper/new_version/2024-10-29-01-14-33-906-01646970520 branch from af7a751 to 247e3b9 Compare October 29, 2024 01:14
Before, the function only returned dependencies, which was defined in required_dependencies. Now, the function also returns dependencies, which are (implicit) dependencies of the dependencies looking for.

Example: required_dependencies=["QEDfields"]
returned before: ["QEDfields"]
returns now: ["QEDbase", "QEDcore", "QEDfields"]
@SimeonEhrig
Copy link
Member

I hijacked the PR because bumping up the compat yaml triggered a bug in the SetupDevEnv.jl script.

calculate_linear_dependency_ordering() did not search for implicit dependencies of dependencies looking for. Instead it only return dependencies which was contained in the input package dependency list.

Before, the function only returned dependencies, which was defined in required_dependencies. Now, the function also returns dependencies, which are (implicit) dependencies of the dependencies looking for.

Example: required_dependencies=["QEDfields"]
returned before: ["QEDfields"]
returns now: ["QEDbase", "QEDcore", "QEDfields"]

@SimeonEhrig SimeonEhrig changed the title CompatHelper: bump compat for QEDcore to 0.2, (keep existing compat) Fixed calculate_linear_dependency_ordering() and bump versions to QEDcore 0.2 and QEDbase 0.3 Oct 29, 2024
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimeonEhrig SimeonEhrig merged commit 457dba2 into dev Oct 29, 2024
3 checks passed
@SimeonEhrig SimeonEhrig deleted the compathelper/new_version/2024-10-29-01-14-33-906-01646970520 branch October 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants