Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: implement GPU test support #96

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Nov 18, 2024

Implement support for running unit tests on Nvidia and AMD GPU runner.
Implement unit tests for all unit test generator functions.

- CUDA and AMDGPU are supported
@SimeonEhrig SimeonEhrig force-pushed the ciGPUSupport branch 2 times, most recently from 264368c to a9faef1 Compare November 19, 2024 10:31
- fix small bug in add_unit_test_verify_job_yaml!() if stage entry did not already exist
- fix small bug in _get_nightly_unit_test(), which avoids setting custom base image
@SimeonEhrig SimeonEhrig marked this pull request as ready for review November 25, 2024 16:37
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, we should wait until the discussion in QEDjl-project/QEDbase.jl#141 is resolved before merging this.

Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks like we can merge this without further changes 👍

@AntonReinhard AntonReinhard merged commit 0a56f16 into QEDjl-project:dev Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants