Merge pull request #336 from QGIS-Contribution/packaging/set-max-qgis…

…-version update(packaging): set QGIS maximum version
QGIS-Contribution · May 13, 2024 · 15086cb · 15086cb
2 parents 132d7d0 + 4bcc026
commit 15086cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/qgis_resource_sharing/metadata.txt b/qgis_resource_sharing/metadata.txt
@@ -16,7 +16,7 @@ tracker=https://github.com/QGIS-Contribution/QGIS-ResourceSharing/issues/
 # versioning
 version=1.1.0-beta1
 qgisMinimumVersion=3.22
-qgisMaximumVersion=3.99
+qgisMaximumVersion=3.34.5
 experimental=True
 deprecated=False
 changelog=
diff --git a/tests/unit/test_plg_metadata.py b/tests/unit/test_plg_metadata.py
@@ -57,6 +57,7 @@ def test_metadata_types(self):
         # misc
         self.assertLessEqual(len(__about__.__title_clean__), len(__about__.__title__))
 
+        # QGIS versions
         # QGIS versions
         self.assertIsInstance(
             __about__.__plugin_md__.get("general").get("qgisminimumversion"), str
@@ -66,10 +67,13 @@ def test_metadata_types(self):
             __about__.__plugin_md__.get("general").get("qgismaximumversion"), str
         )
 
-        self.assertLessEqual(
-            float(__about__.__plugin_md__.get("general").get("qgisminimumversion")),
-            float(__about__.__plugin_md__.get("general").get("qgismaximumversion")),
+        min_version_parsed = parse(
+            __about__.__plugin_md__.get("general").get("qgisminimumversion")
+        )
+        max_version_parsed = parse(
+            __about__.__plugin_md__.get("general").get("qgismaximumversion")
         )
+        self.assertLessEqual(min_version_parsed, max_version_parsed)
 
     def test_required_metadata(self):
         """Test that the plugin __init__ will validate on plugins.qgis.org."""