Replace QWebViews by native Qt widgets #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitjano
force-pushed
the
wip/ptitjano/remove-js
branch
from
09c0b41 to
f032f35
Compare
|
@ptitjano any chance to see it merged before mid-April? |
I will work on it next week. |
AuBousquet
force-pushed
the
wip/ptitjano/remove-js
branch
from
6e63380 to
f032f35
Compare
There is no need to use a webview to display a title and some description. With this new logic, there are no two different widgets to display some collection information: - a label to display the description of the tab (empty state) - a webview to display a collection description The next commits will remove this remaining webview.
This replaces the previous solution based on a QWebView.
Its usage has been replaced by `get_collection` which does not need to render html.
`get_resource_status` was only introduced while `get_html` was still present with `get_collection`.
This was used when a QWebView was used to display a collection information. This is not the case anymore.
This was used when a QwebView was used to display a collection information. This is not the case anymore.
This makes it easier to understand and use.
ptitjano
force-pushed
the
wip/ptitjano/remove-js
branch
from
f032f35 to
97e1fcc
Compare
This comment has aged very badly. |
|
I have just rebased this PR. This PR removed the usage of From my point of view, it is ready. @Guts @AuBousquet Could you test it please? |
Guts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, there is no need to use WebView and all the specific js/css resources have been removed:
jqueryandboostrap.