-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding qmcfinitesize tool #2329
Merged
Merged
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2b977cf
broken, but initial update of qmcfinite to new code
camelto2 545c267
edits to make qmcfinitesize up to date with develop
camelto2 638152d
changes to output formatting
camelto2 519ba94
Merge branch 'develop' into qmcFScorr
camelto2 2a3387b
clang-formatting
camelto2 0150c9b
removed empty file SkParserHDF5.h
camelto2 0326b05
remove unused code
camelto2 9493edb
improved spherical grid and handling cases outside spline grid
camelto2 c741895
add warning for S(k) not being convegred
camelto2 901c0ef
small fix
camelto2 4e69879
Merge remote-tracking branch 'upstream/develop' into qmcFScorr
camelto2 d21f65b
isolate qmcfinitesize in cmake
camelto2 3f34114
small change to spherical_grid
camelto2 4575b2b
refactoring for error estimates
camelto2 273c40b
add stats function, and get potential corr ready for bootstrap
camelto2 971336b
FS corrections with bootstrapped error estimate
camelto2 2b180af
Merge remote-tracking branch 'upstream/develop' into qmcFScorr
camelto2 920fe12
clang format and remove unused CellParserBase
camelto2 e425e64
fix to rng to work with mixed precision build
camelto2 65e8602
removed empty CMakeLists
camelto2 f5a36af
Merge remote-tracking branch 'upstream/develop' into qmcFScorr
camelto2 f852a4c
initial unit test architecture for QMCTools and QMCFiniteSize
camelto2 c0b999f
adding unit test, interface to vlr_k in LRHandlers
camelto2 d06cda6
Merge remote-tracking branch 'upstream/develop' into qmcFScorr
camelto2 327a9e2
clang-formatting and copyright updates on touched files
camelto2 34a226f
Merge branch 'develop' into qmcFScorr
prckent dcada08
fix constructor initialization order and no return type
camelto2 15cf71f
Merge remote-tracking branch 'upstream/develop' into qmcFScorr
camelto2 a506037
Merge remote-tracking branch 'origin/qmcFScorr' into qmcFScorr
camelto2 5d9e634
to trigger the CI
PDoakORNL 8f7dba4
fix compiler warnings for return types and QMCFiniteSize initializatino
camelto2 2f8ad91
Merge branch 'qmcFScorr' of https://github.com/camelto2/qmcpack into …
camelto2 2113d4c
to trigger CI
PDoakORNL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Jeongnim Kim, [email protected], University of Illinois at Urbana-Champaign | ||
// Jeremy McMinnis, [email protected], University of Illinois at Urbana-Champaign | ||
|
@@ -78,8 +78,8 @@ void EwaldHandler::fillFk(KContainer& KList) | |
else | ||
{ | ||
#if OHMMS_DIM == 2 | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 2 * M_PI / Volume; | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 2 * M_PI / Volume; | ||
for (int ks = 0, ki = 0; ks < Fk_symm.size(); ks++) | ||
{ | ||
mRealType t2e = KList.ksq[ki] * kgauss; | ||
|
@@ -90,8 +90,8 @@ void EwaldHandler::fillFk(KContainer& KList) | |
} | ||
PreFactors[3] = 0.0; | ||
#elif OHMMS_DIM == 3 | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
for (int ks = 0, ki = 0; ks < Fk_symm.size(); ks++) | ||
{ | ||
mRealType t2e = KList.ksq[ki] * kgauss; | ||
|
@@ -100,27 +100,51 @@ void EwaldHandler::fillFk(KContainer& KList) | |
while (ki < KList.kshell[ks + 1] && ki < Fk.size()) | ||
Fk[ki++] = uk; | ||
} | ||
PreFactors[3] = 0.0; | ||
PreFactors[3] = 0.0; | ||
#endif | ||
} | ||
app_log().flush(); | ||
} | ||
|
||
EwaldHandler::mRealType EwaldHandler::evaluate_slab(mRealType z, | ||
const std::vector<int>& kshell, | ||
const pComplexType* restrict eikr_i, | ||
const pComplexType* restrict eikr_j) | ||
EwaldHandler::mRealType EwaldHandler::evaluate_vlr_k(mRealType k) | ||
{ | ||
mRealType zp = z * Sigma; | ||
mRealType vk = -SlabFunc0(z, zp); | ||
//cout << "### SLAB " << z << " " << zp << std::endl; | ||
for (int ks = 0, ki = 0; ks < MaxKshell; ks++) | ||
mRealType uk = 0.0; | ||
if (SuperCellEnum == SUPERCELL_SLAB) | ||
{ | ||
mRealType u = 0; //\sum Real (e^ikr_i e^(-ikr_j)) | ||
for (; ki < kshell[ks + 1]; ki++, eikr_i++, eikr_j++) | ||
u += ((*eikr_i).real() * (*eikr_j).real() + (*eikr_i).imag() * (*eikr_j).imag()); | ||
vk += u * Fk_symm[ks] * SlabFuncK(ks, z, zp); | ||
mRealType knorm = M_PI / Area; | ||
uk = knorm / k; //pi/(A*k) | ||
} | ||
else | ||
{ | ||
#if OHMMS_DIM == 2 | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 2 * M_PI / Volume; | ||
mRealType k2 = k * k; | ||
uk = knorm * std::exp(-k2 * kgauss) / k2; | ||
#elif OHMMS_DIM == 3 | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
mRealType k2 = k * k; | ||
uk = knorm * std::exp(-k2 * kgauss) / k2; | ||
} | ||
#endif | ||
return uk; | ||
} | ||
|
||
EwaldHandler::mRealType EwaldHandler::evaluate_slab(mRealType z, const std::vector<int>& kshell, | ||
const pComplexType* restrict eikr_i, | ||
const pComplexType* restrict eikr_j) | ||
{ | ||
mRealType zp = z * Sigma; | ||
mRealType vk = -SlabFunc0(z, zp); | ||
//cout << "### SLAB " << z << " " << zp << std::endl; | ||
for (int ks = 0, ki = 0; ks < MaxKshell; ks++) | ||
{ | ||
mRealType u = 0; //\sum Real (e^ikr_i e^(-ikr_j)) | ||
for (; ki < kshell[ks + 1]; ki++, eikr_i++, eikr_j++) | ||
u += ((*eikr_i).real() * (*eikr_j).real() + (*eikr_i).imag() * (*eikr_j).imag()); | ||
vk += u * Fk_symm[ks] * SlabFuncK(ks, z, zp); | ||
} | ||
return vk; | ||
} | ||
return vk; | ||
} | ||
} // namespace qmcplusplus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Jeongnim Kim, [email protected], University of Illinois at Urbana-Champaign | ||
// Jeremy McMinnis, [email protected], University of Illinois at Urbana-Champaign | ||
|
@@ -93,6 +93,8 @@ class EwaldHandler : public LRHandlerBase | |
*/ | ||
inline mRealType srDf(mRealType r, mRealType rinv) { return 0.0; } | ||
|
||
inline mRealType evaluate_vlr_k(mRealType k) override; | ||
|
||
void fillFk(KContainer& KList); | ||
|
||
/** evaluate k-dependent | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Raymond Clay III, [email protected], Lawrence Livermore National Laboratory | ||
// | ||
|
@@ -61,8 +61,8 @@ void EwaldHandler3D::fillFk(KContainer& KList) | |
|
||
Fk_symm.resize(MaxKshell); | ||
kMag.resize(MaxKshell); | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
for (int ks = 0, ki = 0; ks < Fk_symm.size(); ks++) | ||
{ | ||
mRealType t2e = KList.ksq[ki] * kgauss; | ||
|
@@ -78,4 +78,13 @@ void EwaldHandler3D::fillFk(KContainer& KList) | |
PreFactors[3] = 0.0; | ||
app_log().flush(); | ||
} | ||
|
||
EwaldHandler3D::mRealType EwaldHandler3D::evaluate_vlr_k(mRealType k) | ||
{ | ||
mRealType kgauss = 1.0 / (4 * Sigma * Sigma); | ||
mRealType knorm = 4 * M_PI / Volume; | ||
mRealType k2 = k * k; | ||
return knorm * std::exp(-k2 * kgauss) / k2; | ||
} | ||
|
||
} // namespace qmcplusplus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Raymond Clay III, [email protected], Lawrence Livermore National Laboratory | ||
// | ||
|
@@ -75,7 +75,9 @@ class EwaldHandler3D : public LRHandlerBase | |
return v0; | ||
} | ||
|
||
inline mRealType evaluateLR_r0() { return 2.0 * Sigma / std::sqrt(M_PI); } | ||
mRealType evaluate_vlr_k(mRealType k) override; | ||
|
||
mRealType evaluateLR_r0() { return 2.0 * Sigma / std::sqrt(M_PI); } | ||
|
||
/** evaluate the first derivative of the short range part at r | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Jeongnim Kim, [email protected], University of Illinois at Urbana-Champaign | ||
// Jeremy McMinnis, [email protected], University of Illinois at Urbana-Champaign | ||
|
@@ -55,6 +55,8 @@ struct LRHandlerBase | |
///Coefficient for strain fit. | ||
std::vector<mRealType> gstraincoefs; | ||
|
||
virtual mRealType evaluate_vlr_k(mRealType k) = 0; | ||
|
||
|
||
//constructor | ||
explicit LRHandlerBase(mRealType kc) : MaxKshell(0), LR_kc(kc), LR_rc(0), ClassName("LRHandlerBase") {} | ||
|
@@ -89,6 +91,19 @@ struct LRHandlerBase | |
return vk; | ||
} | ||
|
||
inline mRealType evaluate_w_sk(const std::vector<int>& kshell, const pRealType* restrict sk) | ||
{ | ||
mRealType vk = 0.0; | ||
for (int ks = 0, ki = 0; ks < MaxKshell; ks++) | ||
{ | ||
mRealType u = 0; | ||
for (; ki < kshell[ks + 1]; ki++) | ||
u += (*sk++); | ||
vk += Fk_symm[ks] * u; | ||
} | ||
return vk; | ||
} | ||
|
||
inline mRealType evaluate(const std::vector<int>& kshell, | ||
const pRealType* restrict rk1_r, | ||
const pRealType* restrict rk1_i, | ||
|
@@ -303,19 +318,20 @@ struct DummyLRHandler : public LRHandlerBase | |
Fk.resize(KList.kpts_cart.size()); | ||
for (ksh = 0, ik = 0; ksh < MaxKshell; ksh++, ik++) | ||
{ | ||
mRealType v = norm * myFunc(kk[KList.kshell[ksh]]); //rpa=u0/kk[ik]; | ||
mRealType v = norm * myFunc(kk[KList.kshell[ksh]]); //rpa=u0/kk[ik]; | ||
Fk_symm[ksh] = v; | ||
for (; ik < KList.kshell[ksh + 1]; ik++) | ||
Fk[ik] = v; | ||
} | ||
} | ||
|
||
mRealType evaluate_vlr_k(mRealType k) override { return 0.0; } | ||
mRealType evaluate(mRealType r, mRealType rinv) { return 0.0; } | ||
mRealType evaluateLR(mRealType r) { return 0.0; } | ||
mRealType srDf(mRealType r, mRealType rinv) { return 0.0; } | ||
void Breakup(ParticleSet& ref, mRealType rs_in) {} | ||
void resetTargetParticleSet(ParticleSet& ref) {} | ||
virtual LRHandlerBase* makeClone(ParticleSet& ref){return new DummyLRHandler<Func>(LR_kc);} | ||
void resetTargetParticleSet(ParticleSet& ref) {} | ||
virtual LRHandlerBase* makeClone(ParticleSet& ref) { return new DummyLRHandler<Func>(LR_kc); } | ||
}; | ||
|
||
} // namespace qmcplusplus | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Raymond Clay III, [email protected], Lawrence Livermore National Laboratory | ||
// Mark A. Berrill, [email protected], Oak Ridge National Laboratory | ||
|
@@ -117,6 +117,8 @@ class LRHandlerSRCoulomb : public LRHandlerBase | |
return v; | ||
} | ||
|
||
inline mRealType evaluate_vlr_k(mRealType k) { return evalYk(k); } | ||
|
||
/** evaluate the first derivative of the short range part at r | ||
* | ||
* @param r radius | ||
|
@@ -282,7 +284,7 @@ class LRHandlerSRCoulomb : public LRHandlerBase | |
LRBreakup<BreakupBasis> breakuphandler(Basis); | ||
//Find size of basis from cutoffs | ||
mRealType kc = (LR_kc < 0) ? ref.LR_kc : LR_kc; | ||
LR_kc = kc; // set internal kc | ||
LR_kc = kc; // set internal kc | ||
//mRealType kc(ref.LR_kc); //User cutoff parameter... | ||
//kcut is the cutoff for switching to approximate k-point degeneracies for | ||
//better performance in making the breakup. A good bet is 30*K-spacing so that | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Ken Esler, [email protected], University of Illinois at Urbana-Champaign | ||
// Bryan Clark, [email protected], Princeton University | ||
|
@@ -102,7 +102,8 @@ class LRHandlerTemp : public LRHandlerBase | |
inline mRealType evaluate(mRealType r, mRealType rinv) | ||
{ | ||
mRealType v = 0.0; | ||
if (r>=LR_rc) return v; | ||
if (r >= LR_rc) | ||
return v; | ||
v = myFunc(r, rinv); | ||
for (int n = 0; n < coefs.size(); n++) | ||
v -= coefs[n] * Basis.h(n, r); | ||
|
@@ -118,21 +119,25 @@ class LRHandlerTemp : public LRHandlerBase | |
{ | ||
APP_ABORT("LRHandlerTemp::srDF not implemented (missing gcoefs)"); | ||
mRealType df = 0.0; | ||
if (r>=LR_rc) return df; | ||
if (r >= LR_rc) | ||
return df; | ||
df = myFunc.df(r); | ||
//RealType df = myFunc.df(r, rinv); | ||
for (int n = 0; n < coefs.size(); n++) | ||
df -= gcoefs[n] * Basis.dh_dr(n, r); | ||
return df; | ||
} | ||
|
||
inline mRealType evaluate_vlr_k(mRealType k) { return evalFk(k); } | ||
|
||
|
||
/** evaluate the contribution from the long-range part for for spline | ||
*/ | ||
inline mRealType evaluateLR(mRealType r) | ||
{ | ||
mRealType v = 0.0; | ||
if (r>=LR_rc) return myFunc(r, 1./r); | ||
if (r >= LR_rc) | ||
return myFunc(r, 1. / r); | ||
for (int n = 0; n < coefs.size(); n++) | ||
v += coefs[n] * Basis.h(n, r); | ||
return v; | ||
|
@@ -208,7 +213,7 @@ class LRHandlerTemp : public LRHandlerBase | |
LRBreakup<BreakupBasis> breakuphandler(Basis); | ||
//Find size of basis from cutoffs | ||
mRealType kc = (LR_kc < 0) ? ref.LR_kc : LR_kc; | ||
LR_kc = kc; // set internal kc | ||
LR_kc = kc; // set internal kc | ||
//RealType kc(ref.LR_kc); //User cutoff parameter... | ||
//kcut is the cutoff for switching to approximate k-point degeneracies for | ||
//better performance in making the breakup. A good bet is 30*K-spacing so that | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Miguel Morales, [email protected], Lawrence Livermore National Laboratory | ||
// Jeremy McMinnis, [email protected], University of Illinois at Urbana-Champaign | ||
|
@@ -155,6 +155,8 @@ struct LRRPABFeeHandlerTemp : public LRHandlerBase | |
return vk; | ||
} | ||
|
||
inline mRealType evaluate_vlr_k(mRealType k) override { return evalFk(k); } | ||
|
||
private: | ||
inline mRealType evalFk(mRealType k) | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
// This file is distributed under the University of Illinois/NCSA Open Source License. | ||
// See LICENSE file in top directory for details. | ||
// | ||
// Copyright (c) 2016 Jeongnim Kim and QMCPACK developers. | ||
// Copyright (c) 2020 QMCPACK developers. | ||
// | ||
// File developed by: Jeongnim Kim, [email protected], University of Illinois at Urbana-Champaign | ||
// Jeremy McMinnis, [email protected], University of Illinois at Urbana-Champaign | ||
|
@@ -156,6 +156,9 @@ struct LRRPAHandlerTemp : public LRHandlerBase | |
return vk; | ||
} | ||
|
||
// use what is put in fillFk. Multiplies evalFk by -1 | ||
inline mRealType evaluate_vlr_k(mRealType k) override { return -1.0 * evalFk(k); } | ||
|
||
private: | ||
inline mRealType evalFk(mRealType k) | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check if the dependencies here are necessary?
Do you need qmcwfs or just einspline?
Is qmc target really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the moment, it only needs einspline. this will change in the future when a kinetic energy FS correction is added, which will depend on the 2body jastrow and a kspace jastrow. if it is preferable to just add the various .cpp files in FSSRCS that each thing depends on I can do that instead as opposed to targetting libraries that include those dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us put einspline and change it to qmcwfs when actual WFS dependence comes in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For user friendliness, this tool should work with any QMCPACK xml input file. Unfortunately, even if you're not using any wavefunction specific information, the system initialization path that allows you to grab a particle set and box from ESHDF file, in the event it's not specified in the XML, needs to go through the wavefunction builder. So I think that qmcwfs is a necessary dependency right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I see. The dependency is needed right now.