-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus support for Kagayaki cluster at JAIST #4598
Conversation
@ichibha all tests pass with |
The Nexus tests are failing in CI. Maybe we need some more examples on how to add a machine and have the tests pass? |
At least, I have to add Kagayaki in test_machines.py. I try to solve the errors myself first to pass this PR. |
See also #4068 (comment) |
@ichibha any luck? |
@jtkrogel Currently, this specific test is the only one that fails. Is it related to the updates I made? Before submitting the pull request, I have two tasks to complete:
|
@jtkrogel I wanted to inform you that the current version of our feature branch successfully passes all tests in the nxs-test suite with the exception of test 61/qdens_radial. I've been able to confirm that the generated PBS files are functioning as expected. Given the above, I believe the branch is in a suitable state for merging. Please could you review and consider approving the merge request? |
I performed nxs-test of the latest develop branch, and 61/qdens_radial failed. |
Test this please |
@jtkrogel Is PR this okay with you? The nexus tests pass for me locally. |
Yes it is. The qdens radial issue may be environment dependent and should be handled separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion above
Proposed changes
This PR implements the Nexus settings for Kagayaki cluster at JAIST.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Kagayaki cluster at JAIST.
Checklist