-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]nexus rmg updates #4747
base: develop
Are you sure you want to change the base?
[WIP]nexus rmg updates #4747
Conversation
Kgasperich/nexus rmg pptype
Kgasperich/nexus rmg pptype
@anbenali what is still needed to move this out of WIP for review? |
I want to have it working with the MSD route as well. However, we can still just create another PR. |
Better to keep things moving imo. |
Checking on the status of this. It still has [WIP] but does anything still need to be done besides solving the conflict on qmcpack.py? |
@anbenali @kgasperich ping |
Ping. Can you remove the wip or is another update needed? |
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.