Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused template parameter #4786

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

quantumsteve
Copy link
Contributor

@quantumsteve quantumsteve commented Oct 19, 2023

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

The member function VectorSoaContainer::copyIn has a template parameter T1 that in the current codebase is always equal to T. I see more risks than benefits to the additional functionality.

Found while working on #4684.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

@williamfgc
Copy link
Contributor

Test this please

@ye-luo ye-luo merged commit 148d66d into QMCPACK:develop Oct 20, 2023
41 checks passed
@quantumsteve quantumsteve deleted the unused_template_parameter branch October 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants